remove deleting network adapter when no endpoints #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cns/hnsclient/hnsclient_windows.go
Outdated
|
|
||
| for _, iface := range interfaces { | ||
| addrs, _ := iface.Addrs() | ||
| logger.Printf("[net] Network interface: %+v with IP: %+v", iface, addrs) |
Member
There was a problem hiding this comment.
probably remove [net] from this log line or add it to other log lines you have added here. Not sure what the existing log line do
ashvindeodhar
approved these changes
Jun 14, 2021
Contributor
Author
|
aks swift tests are being recovered and this change is windows specific so not relevant here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: