Skip to content

chore: Deprecating HostNetAgent Processed Telemetry #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2021
Merged

chore: Deprecating HostNetAgent Processed Telemetry #903

merged 1 commit into from
Jun 21, 2021

Conversation

@jaer-tsun
Copy link
Contributor

@jaer-tsun jaer-tsun commented Jun 15, 2021

Reason for Change:

Removing telemetry processed on HostNetAgent

Notes:

@jaer-tsun jaer-tsun force-pushed the removeHostTelemetry branch 6 times, most recently from 881250b to 16a0284 Compare June 15, 2021 22:50
@jaer-tsun jaer-tsun force-pushed the removeHostTelemetry branch from 16a0284 to 0b8d566 Compare June 15, 2021 22:58
@jaer-tsun jaer-tsun requested a review from tamilmani1989 June 17, 2021 15:50
neaggarwMS
neaggarwMS reviewed Jun 21, 2021
View reviewed changes
log/logger.go
return
}

logger.mutex.Lock()
Copy link
Member

@neaggarwMS neaggarwMS Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger.mutex.Lock()

Do we still need to take Mutex lock?

neaggarwMS
neaggarwMS reviewed Jun 21, 2021
View reviewed changes
log/logger.go
return
}

logger.mutex.Lock()
Copy link
Member

@neaggarwMS neaggarwMS Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger.mutex.Lock()

missing mutex lock

neaggarwMS
neaggarwMS reviewed Jun 21, 2021
View reviewed changes
log/logger.go

// Errorf logs a formatted string at info level and sends the string to TelemetryBuffer.
func (logger *Logger) Errorf(format string, args ...interface{}) {
logger.Logf(format, args...)
Copy link
Member

@neaggarwMS neaggarwMS Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutex lock?

neaggarwMS
neaggarwMS approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@neaggarwMS neaggarwMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jaer-tsun jaer-tsun merged commit 8acc37d into Azure:master Jun 21, 2021
@jaer-tsun jaer-tsun deleted the removeHostTelemetry branch June 21, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neaggarwMS neaggarwMS neaggarwMS approved these changes

@tamilmani1989 tamilmani1989 Awaiting requested review from tamilmani1989

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaer-tsun @neaggarwMS