Conversation
#sign-off |
@sptramer - if this PR could be merged, that would be much appreciated. |
@erickson-doug or @sptramer - can you merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR requests changes to make the sample scripts operational.
event-grid/subscribe-to-blob-storage/subscribe-to-blob-storage.ps1
Outdated
Show resolved
Hide resolved
event-grid/subscribe-to-custom-topic-preview/subscribe-to-custom-topic-preview.ps1
Outdated
Show resolved
Hide resolved
event-grid/subscribe-to-resource-group-preview/subscribe-to-resource-group-preview.ps1
Outdated
Show resolved
Hide resolved
@sptramer - thanks for the feedback. I have made the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other changes required for scripts to work correctly.
event-grid/subscribe-to-resource-group-preview/subscribe-to-resource-group-preview.ps1
Show resolved
Hide resolved
@sptramer - I think I have everything fixed now. |
event-grid/subscribe-to-custom-topic-preview/subscribe-to-custom-topic-preview.ps1
Outdated
Show resolved
Hide resolved
Get the following error from
Not clear why I have this error. The provided subscription information was valid. Endpoints are validated by an API call which will report a timeout/fail if they're not correct (no correct endpoints were used in testing, because I have no idea how to set them up.)
|
Please make sure that you run and validate the scripts before signing off again. |
@sptramer - sorry about the errors. I have rerun all of the scripts and they are now working as expected. The subscription errors you are seeing are probably related to not having a valid endpoint, and not having a token for the subscription. Event Grid requires a response from the endpoint. Also, you need event write access for the Azure subscription you provide. |
@tfitzmac Is there an easy way to set up an endpoint so that I can use it in testing to avoid errors like those? |
@sptramer - the easiest way is to deploy a pre-built event viewer web app. Note that you have to add "/api/updates" to the base URL when subscribing to events. That path is set up to process event subscription requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking changes requested, let me know if you just want me to merge.
event-grid/subscribe-to-azure-subscription-preview/subscribe-to-azure-subscription-preview.ps1
Outdated
Show resolved
Hide resolved
Comments were changed |
No description provided.