Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to lease scanner #428

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Minor changes to lease scanner #428

merged 2 commits into from
Feb 6, 2019

Conversation

JamesBirdsall
Copy link
Contributor

@JamesBirdsall JamesBirdsall commented Feb 6, 2019 •
edited

Description

  • Add logging if the scanner threw an exception.
  • Change logging level to warn when scanner shuts down.
  • Scanner can call EventProcessorOptions.notifyOfException, which calls user code. Change notifyOfException to defensively catch any exceptions coming out of user code.

@JamesBirdsall JamesBirdsall merged commit 5826288 into Azure:dev Feb 6, 2019
@JamesBirdsall JamesBirdsall deleted the protect branch February 6, 2019 19:04
Jgomez13 pushed a commit that referenced this pull request May 17, 2024
@JamesBirdsall
Minor changes to lease scanner (#428)
0e52fd7 
* Add logging if the scanner threw an exception.
* Change logging level to warn when scanner shuts down for any reason.
* Scanner can call EventProcessorOptions.notifyOfException, which calls user code. Change notifyOfException to defensively catch any exceptions coming out of user code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjkwak sjkwak sjkwak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamesBirdsall @sjkwak