New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default appsettings.json file to local.settings.json #122

Closed
lindydonna opened this Issue Apr 18, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@lindydonna
Contributor

lindydonna commented Apr 18, 2017

We've gotten feedback from customers that the name appsettings.json is confusing. I did a poll on the Advisors group. We got 50+ responses, with most voting for the name local.settings.json.

We should do the following:

  • Change the default file that is created on func init
  • On all commands that use the settings file (e.g. func host start, func settings), print a deprecation warning if appsettings.json is used

    Warning: The filename 'appsettings.json' is deprecated. Rename it to local.settings.json

  • If both files exist, print a warning

    Warning: found both 'local.settings.json' and 'appsettings.json'. Ignoring 'appsettings.json'.

@nitro52

This comment has been minimized.

Show comment
Hide comment
@nitro52

nitro52 May 8, 2017

I got the warning so i renamed appsettings.json to local.settings.json. This worked fine. Then i tried connecting to azure using the "func azure login" commands and "func azure functionapp fetch" which created a new appsettings.json instead of updating local.settings.json. I manually copied into local.settings.json. but it seems that the cli commands still expect appsettings.json.

has this been fixed just not released?

nitro52 commented May 8, 2017

I got the warning so i renamed appsettings.json to local.settings.json. This worked fine. Then i tried connecting to azure using the "func azure login" commands and "func azure functionapp fetch" which created a new appsettings.json instead of updating local.settings.json. I manually copied into local.settings.json. but it seems that the cli commands still expect appsettings.json.

has this been fixed just not released?

@lindydonna

This comment has been minimized.

Show comment
Hide comment
@lindydonna

lindydonna May 8, 2017

Contributor

@nitro52 It was supposed to be released with the fix you mentioned, but it looks like we missed a code path. Thanks for the bug report!

Reopening issue.

Contributor

lindydonna commented May 8, 2017

@nitro52 It was supposed to be released with the fix you mentioned, but it looks like we missed a code path. Thanks for the bug report!

Reopening issue.

@lindydonna lindydonna reopened this May 8, 2017

@ahmelsayed

This comment has been minimized.

Show comment
Hide comment
@ahmelsayed

ahmelsayed May 8, 2017

Contributor

I can't repro this. func azure functionapp fetch puts the settings correctly in my local.settings.json. Are you sure you're using the latest 96 release?

Contributor

ahmelsayed commented May 8, 2017

I can't repro this. func azure functionapp fetch puts the settings correctly in my local.settings.json. Are you sure you're using the latest 96 release?

@lindydonna

This comment has been minimized.

Show comment
Hide comment
@lindydonna

lindydonna May 8, 2017

Contributor

@nitro52 Same here, it all works correctly on Beta96. Closing issue, let us know if you have an updated repro.

Contributor

lindydonna commented May 8, 2017

@nitro52 Same here, it all works correctly on Beta96. Closing issue, let us know if you have an updated repro.

@lindydonna lindydonna closed this May 8, 2017

@nitro52

This comment has been minimized.

Show comment
Hide comment
@nitro52

nitro52 May 9, 2017

Sorry guys, i did a npm i -g azure-functions-core-tools a day or two a go, at least i thought i did. seems like i was on 94 not 96. Updated and it looks fine.

nitro52 commented May 9, 2017

Sorry guys, i did a npm i -g azure-functions-core-tools a day or two a go, at least i thought i did. seems like i was on 94 not 96. Updated and it looks fine.

@lindydonna

This comment has been minimized.

Show comment
Hide comment
@lindydonna

lindydonna May 9, 2017

Contributor

@nitro52 thanks for confirming

Contributor

lindydonna commented May 9, 2017

@nitro52 thanks for confirming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment