Skip to content
Permalink
Browse files

Upgrading StyleCop to Analyzer version, fixing some style issues

  • Loading branch information...
fabiocav committed Apr 5, 2017
1 parent e402879 commit 3b3e8cb8312060a475d4eb0418fafb4d80f12326
Showing with 671 additions and 836 deletions.
  1. +0 −383 Settings.StyleCop
  2. +6 −0 src/Packages/Packages.csproj
  3. +4 −0 src/Packages/packages.config
  4. BIN src/WebJobs.Script.Extensibility/GlobalSuppressions.cs
  5. +1 −1 src/WebJobs.Script.Extensibility/Properties/AssemblyInfo.cs
  6. +2 −2 src/WebJobs.Script.Extensibility/ScriptBinding.cs
  7. +3 −4 src/WebJobs.Script.Extensibility/ScriptBindingContext.cs
  8. +8 −7 src/WebJobs.Script.Extensibility/WebJobs.Script.Extensibility.csproj
  9. +1 −1 src/WebJobs.Script.Extensibility/packages.config
  10. +5 −4 src/WebJobs.Script.Host/GlobalSuppressions.cs
  11. +1 −1 src/WebJobs.Script.Host/Program.cs
  12. +1 −1 src/WebJobs.Script.Host/Properties/AssemblyInfo.cs
  13. +8 −2 src/WebJobs.Script.Host/WebJobs.Script.Host.csproj
  14. +1 −1 src/WebJobs.Script.Host/packages.config
  15. +1 −1 src/WebJobs.Script.WebHost/App_Start/WebHostResolver.cs
  16. +1 −1 src/WebJobs.Script.WebHost/Controllers/HomeController.cs
  17. +2 −2 src/WebJobs.Script.WebHost/Controllers/KeysController.cs
  18. +40 −35 src/WebJobs.Script.WebHost/Diagnostics/MetricsEventManager.cs
  19. +4 −7 src/WebJobs.Script.WebHost/Filters/AuthorizationLevelAttribute.cs
  20. +3 −3 src/WebJobs.Script.WebHost/Filters/SystemAuthorizationLevelAttribute.cs
  21. +1 −0 src/WebJobs.Script.WebHost/Formatting/PlaintextMediaTypeFormatter.cs
  22. +13 −4 src/WebJobs.Script.WebHost/GlobalSuppressions.cs
  23. +1 −1 src/WebJobs.Script.WebHost/Handlers/WebScriptHostHandler.cs
  24. +1 −0 src/WebJobs.Script.WebHost/Models/ApiErrorModel.cs
  25. +1 −1 src/WebJobs.Script.WebHost/Properties/AssemblyInfo.cs
  26. +14 −15 src/WebJobs.Script.WebHost/Security/BlobStorageSecretsRepository.cs
  27. +0 −15 src/WebJobs.Script.WebHost/Security/DataProtectionKeyValueConverter.cs
  28. +4 −4 src/WebJobs.Script.WebHost/Security/DefaultSecretsRepositoryFactory.cs
  29. 0 src/WebJobs.Script.WebHost/Security/{ISecretRepositoryFactory.cs → ISecretsRepositoryFactory.cs}
  30. +2 −2 src/WebJobs.Script.WebHost/Security/SecretManager.cs
  31. +1 −1 src/WebJobs.Script.WebHost/Security/Serialization/ScriptSecretSerializer.cs
  32. +1 −1 src/WebJobs.Script.WebHost/Security/Serialization/ScriptSecretSerializerV0.cs
  33. +1 −1 src/WebJobs.Script.WebHost/Swagger/SwaggerDocumentManager.cs
  34. +1 −1 src/WebJobs.Script.WebHost/WebHooks/DynamicWebHookReceiverConfig.cs
  35. +1 −2 src/WebJobs.Script.WebHost/WebHooks/WebHookReceiverManager.cs
  36. +9 −3 src/WebJobs.Script.WebHost/WebJobs.Script.WebHost.csproj
  37. +1 −0 src/WebJobs.Script.WebHost/WebScriptHostExceptionHandler.cs
  38. +4 −4 src/WebJobs.Script.WebHost/WebScriptHostManager.cs
  39. +1 −1 src/WebJobs.Script.WebHost/packages.config
  40. +1 −2 src/WebJobs.Script/Binding/ApiHubScriptBindingProvider.cs
  41. +2 −2 src/WebJobs.Script/Binding/BindingContext.cs
  42. +1 −2 src/WebJobs.Script/Binding/CoreExtensionsScriptBindingProvider.cs
  43. +0 −1 src/WebJobs.Script/Binding/DocumentDBScriptBindingProvider.cs
  44. +2 −0 src/WebJobs.Script/Binding/ExtensionBinding.cs
  45. +2 −2 src/WebJobs.Script/Binding/FunctionBinding.cs
  46. +2 −3 src/WebJobs.Script/Binding/Http/HttpRouteFactory.cs
  47. +2 −2 src/WebJobs.Script/Binding/HttpBinding.cs
  48. +1 −2 src/WebJobs.Script/Binding/NotificationHubScriptBindingProvider.cs
  49. +2 −1 src/WebJobs.Script/Binding/ServiceBusScriptBindingProvider.cs
  50. +1 −2 src/WebJobs.Script/Binding/TwilioScriptBindingProvider.cs
  51. +24 −25 src/WebJobs.Script/Binding/WebJobsCoreScriptBindingProvider.cs
  52. +8 −8 src/WebJobs.Script/Config/ScriptHostConfiguration.cs
  53. +2 −2 src/WebJobs.Script/Description/Binding/BindingMetadata.cs
  54. +3 −5 src/WebJobs.Script/Description/DotNet/CSharp/CSharpCompilation.cs
  55. +1 −1 src/WebJobs.Script/Description/DotNet/DotNetCompilationServiceFactory.cs
  56. +1 −1 src/WebJobs.Script/Description/DotNet/DotNetFunctionDescriptorProvider.cs
  57. +6 −3 src/WebJobs.Script/Description/DotNet/DotNetFunctionInvoker.cs
  58. +1 −1 src/WebJobs.Script/Description/DotNet/ExtensionSharedAssemblyProvider.cs
  59. +2 −1 src/WebJobs.Script/Description/DotNet/FSharp/FSharpCompilation.cs
  60. +6 −5 src/WebJobs.Script/Description/DotNet/FSharp/FSharpCompilationService.cs
  61. +4 −4 src/WebJobs.Script/Description/DotNet/FunctionAssemblyLoader.cs
  62. +1 −1 src/WebJobs.Script/Description/DotNet/LocalSharedAssemblyProvider.cs
  63. +3 −3 src/WebJobs.Script/Description/DotNet/PackageManager.cs
  64. +4 −1 src/WebJobs.Script/Description/DotNet/Raw/RawAssemblyCompilation.cs
  65. +4 −1 src/WebJobs.Script/Description/DotNet/Raw/RawAssemblyCompilationService.cs
  66. +2 −2 src/WebJobs.Script/Description/FunctionDescriptor.cs
  67. +1 −1 src/WebJobs.Script/Description/FunctionGenerator.cs
  68. +2 −0 src/WebJobs.Script/Description/FunctionInvocationContext.cs
  69. +3 −3 src/WebJobs.Script/Description/FunctionInvokerBase.cs
  70. +2 −2 src/WebJobs.Script/Description/FunctionLoader.cs
  71. +3 −3 src/WebJobs.Script/Description/Node/NodeFunctionInvoker.cs
  72. +6 −3 src/WebJobs.Script/Description/PackageRestoreResult.cs
  73. +1 −1 src/WebJobs.Script/Description/ParameterDescriptor.cs
  74. 0 ...t/Description/Script/{ScriptFunctionDescriptionProvider.cs → ScriptFunctionDescriptorProvider.cs}
  75. +22 −0 src/WebJobs.Script/Diagnostics/ApplicationPerformanceCounters.cs
  76. +1 −1 src/WebJobs.Script/Diagnostics/ConditionalTraceWriter.cs
  77. +2 −0 src/WebJobs.Script/Diagnostics/FileLoggingMode.cs
  78. +1 −1 src/WebJobs.Script/Diagnostics/IMetricsLogger.cs
  79. +1 −1 src/WebJobs.Script/EnvironmentSettingNames.cs
  80. +1 −1 src/WebJobs.Script/Extensions/AssemblyExtensions.cs
  81. +3 −3 src/WebJobs.Script/Extensions/FileUtility.cs
  82. +1 −1 src/WebJobs.Script/Extensions/HttpRequestMessageExtensions.cs
  83. +1 −1 src/WebJobs.Script/Extensions/IDictionaryExtensions.cs
  84. +1 −3 src/WebJobs.Script/Extensions/TraceWriterExtensions.cs
  85. +15 −5 src/WebJobs.Script/GlobalSuppressions.cs
  86. +3 −2 src/WebJobs.Script/Host/BlobLeaseManager.cs
  87. +4 −1 src/WebJobs.Script/Host/NullScriptHostEnvironment.cs
  88. +22 −24 src/WebJobs.Script/Host/ScriptHost.cs
  89. +4 −4 src/WebJobs.Script/Host/ScriptHostManager.cs
  90. +3 −0 src/WebJobs.Script/Host/ScriptHostState.cs
  91. +2 −2 src/WebJobs.Script/IO/AutoRecoveringFileSystemWatcher.cs
  92. +1 −1 src/WebJobs.Script/Properties/AssemblyInfo.cs
  93. +2 −0 src/WebJobs.Script/PropertyHelper.cs
  94. +2 −2 src/WebJobs.Script/ScriptConstants.cs
  95. +15 −16 src/WebJobs.Script/Utility.cs
  96. +9 −2 src/WebJobs.Script/WebJobs.Script.csproj
  97. +1 −0 src/WebJobs.Script/packages.config
  98. +31 −8 src/src.ruleset
  99. +24 −0 stylecop.json
  100. +8 −0 test/WebJobs.Extensibility.Tests/GlobalSuppressions.cs
  101. +9 −6 test/WebJobs.Extensibility.Tests/Properties/AssemblyInfo.cs
  102. +0 −2 test/WebJobs.Extensibility.Tests/ScriptBindingContextTests.cs
  103. +11 −0 test/WebJobs.Extensibility.Tests/WebJobs.Extensibility.Tests.csproj
  104. +1 −0 test/WebJobs.Extensibility.Tests/packages.config
  105. +2 −1 test/WebJobs.Script.Tests.Integration/ApiHubTestHelper.cs
  106. +4 −5 test/WebJobs.Script.Tests.Integration/BlobLeaseManagerTests.cs
  107. +3 −0 test/WebJobs.Script.Tests.Integration/CSharpEndToEndTests.cs
  108. 0 ...Tests.Integration/Controllers/Keys/{DeleteFunctionKeyScenario.cs → DeleteFunctionKeysScenario.cs}
  109. 0 ...ipt.Tests.Integration/Controllers/Keys/{PostFunctionKeyScenario.cs → PostFunctionKeysScenario.cs}
  110. 0 ...cript.Tests.Integration/Controllers/Keys/{PutFunctionKeyScenario.cs → PutFunctionKeysScenario.cs}
  111. +26 −15 test/WebJobs.Script.Tests.Integration/Diagnostics/MetricsEventManagerTests.cs
  112. +3 −0 test/WebJobs.Script.Tests.Integration/EndToEndTestFixture.cs
  113. +8 −14 test/WebJobs.Script.Tests.Integration/EndToEndTestsBase.cs
  114. +2 −1 test/WebJobs.Script.Tests.Integration/EndToEndTimeoutTests.cs
  115. +4 −0 test/WebJobs.Script.Tests.Integration/FSharpEndToEndTests.cs
  116. +25 −24 test/WebJobs.Script.Tests.Integration/FakeTabularConnectorAdapter.cs
  117. +2 −2 test/WebJobs.Script.Tests.Integration/FunctionGeneratorEndToEndTests.cs
  118. +7 −0 test/WebJobs.Script.Tests.Integration/GlobalSuppressions.cs
  119. +5 −5 test/WebJobs.Script.Tests.Integration/Host/ScriptHostManagerTests.cs
  120. +6 −5 test/WebJobs.Script.Tests.Integration/Host/WebScriptHostManagerTests.cs
  121. +12 −9 test/WebJobs.Script.Tests.Integration/NodeContentTests.cs
  122. +3 −3 test/WebJobs.Script.Tests.Integration/NodeEndToEndTests.cs
  123. +1 −1 test/WebJobs.Script.Tests.Integration/PhpEndToEndTests.cs
  124. +1 −1 test/WebJobs.Script.Tests.Integration/PowerShellEndToEndTests.cs
  125. +5 −5 test/WebJobs.Script.Tests.Integration/Properties/AssemblyInfo.cs
  126. +9 −3 test/WebJobs.Script.Tests.Integration/SamplesEndToEndTests.cs
  127. +12 −5 test/WebJobs.Script.Tests.Integration/WebJobs.Script.Tests.Integration.csproj
  128. +1 −1 test/WebJobs.Script.Tests.Integration/packages.config
  129. +3 −2 test/WebJobs.Script.Tests.Shared/SingleThreadedSynchronizationContext.cs
  130. +1 −1 test/WebJobs.Script.Tests.Shared/TempDirectory.cs
  131. +1 −1 test/WebJobs.Script.Tests.Shared/TestSecretManager.cs
  132. 0 ...ts/Binding/{CoreExtensionsScriptBindingProvider.cs → CoreExtensionsScriptBindingProviderTests.cs}
  133. +2 −1 test/WebJobs.Script.Tests/Binding/SendGridScriptBindingProviderTests.cs
  134. +1 −1 test/WebJobs.Script.Tests/Binding/ServiceBusScriptBindingProviderTests.cs
  135. +2 −2 test/WebJobs.Script.Tests/Controllers/Admin/KeysControllerTests.cs
  136. +2 −2 test/WebJobs.Script.Tests/Controllers/Admin/SwaggerControllerTests.cs
  137. +1 −1 test/WebJobs.Script.Tests/Description/DotNet/CSharp/CSharpFunctionSignatureTests.cs
  138. +8 −2 test/WebJobs.Script.Tests/Description/DotNet/DotNetFunctionInvokerTests.cs
  139. +1 −1 test/WebJobs.Script.Tests/Description/DotNet/ExtensionSharedAssemblyProviderTests.cs
  140. +1 −1 test/WebJobs.Script.Tests/Description/DotNet/FunctionAssemblyLoaderTests.cs
  141. +1 −0 test/WebJobs.Script.Tests/Description/DotNet/PackageManagerTests.cs
  142. +1 −1 test/WebJobs.Script.Tests/Description/FunctionEntryPointResolverTests.cs
  143. +2 −0 test/WebJobs.Script.Tests/Description/Node/NodeFunctionInvokerTests.cs
  144. +1 −1 test/WebJobs.Script.Tests/Description/PowerShell/PowerShellInvokerTests.cs
  145. +1 −1 test/WebJobs.Script.Tests/Extensions/IDictionaryExtensionsTests.cs
  146. +3 −2 test/WebJobs.Script.Tests/Filters/AuthorizationLevelAttributeTests.cs
  147. +4 −4 test/WebJobs.Script.Tests/Filters/JwtAuthenticationAttributeTests.cs
  148. +7 −0 test/WebJobs.Script.Tests/GlobalSuppressions.cs
  149. +1 −0 test/WebJobs.Script.Tests/IO/AutoRecoveringFileSystemWatcherTests.cs
  150. +5 −5 test/WebJobs.Script.Tests/Properties/AssemblyInfo.cs
  151. +1 −0 test/WebJobs.Script.Tests/Security/SecretManagerTests.cs
  152. +1 −1 test/WebJobs.Script.Tests/Security/SecretsRepositoryTests.cs
  153. +3 −2 test/WebJobs.Script.Tests/Swagger/SwaggerDocumentManagerTests.cs
  154. +7 −4 test/WebJobs.Script.Tests/UtilityTests.cs
  155. +1 −1 test/WebJobs.Script.Tests/WebHooks/WebHookReceiverManagerTests.cs
  156. +11 −3 test/WebJobs.Script.Tests/WebJobs.Script.Tests.csproj
  157. +1 −1 test/WebJobs.Script.Tests/packages.config

This file was deleted.

Oops, something went wrong.
@@ -50,8 +50,14 @@
<Link>NuGetProj.settings.targets</Link>
</None>
<None Include="app.config" />
<None Include="packages.config" />
<None Include="tools\install.ps1" />
</ItemGroup>
<ItemGroup>
<Analyzer Include="..\..\packages\StyleCop.Analyzers.1.1.0-beta001\analyzers\dotnet\cs\Newtonsoft.Json.dll" />
<Analyzer Include="..\..\packages\StyleCop.Analyzers.1.1.0-beta001\analyzers\dotnet\cs\StyleCop.Analyzers.CodeFixes.dll" />
<Analyzer Include="..\..\packages\StyleCop.Analyzers.1.1.0-beta001\analyzers\dotnet\cs\StyleCop.Analyzers.dll" />
</ItemGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
<Target Name="Build">
<MSBuild Projects="@(NuGetProject)" Targets="Build" />
Oops, something went wrong.

0 comments on commit 3b3e8cb

Please sign in to comment.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.