Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function proxies json schema missing "comment" attributes on all levels / all subojects #2337

Closed
amadl opened this Issue Jan 20, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@amadl
Copy link

amadl commented Jan 20, 2018

Function proxies json schema missing "comment" attributes on all levels / all subojects

Investigative information

2018-01-20

Function App version (1.0and 2.0-beta)
Function Proxies
Region: all

Repro steps

Provide the steps required to reproduce the problem:

Try to add additional comment attributes in a proxies.json file, you get an error when proxy definitions get loaded by the Function.

Expected behavior

Let us use additional "comment" attributes on all levels of the proxies.json.

Known workarounds

none

Related information

Sample:

{
"$schema": "http://json.schemastore.org/proxies",
"proxies": {
"appl_v1_Form('formname_formversion')_Redirect": {
"matchCondition": {
"route": "/%ENVIRONMENT_APPL%/v1/Form('{formname}/{formversion}')/Redirect",
"methods": ["GET"],
"comment": "HERE GOES MY COMMENT"
},
"backendUri": "https://%LOGICAPP-aim-ail-v1-frm-rdr-lap%",
"comment": "HERE GOES ANOTERH COMMENT",
"requestOverrides": {
"backend.request.method": "post",
"backend.request.headers.Appl-Version": "v1",
"backend.request.headers.Appl-Home": "https://{request.headers.DISGUISED-HOST}/%ENVIRONMENT_APPL%/v1/",
"backend.request.headers.Entity-Name": "Form",
"comment": "AND ANOTHER COMMENT", ......

@christopheranderson

This comment has been minimized.

Copy link
Member

christopheranderson commented Jan 23, 2018

Please move this to a milestone after you've investigated.

@safihamid

This comment has been minimized.

Copy link
Contributor

safihamid commented Feb 27, 2018

This is already working.

The key name is "desc".

here is a sample:

{
"proxies": {
"proxy1 - Simple Get Case": {
"desc":
[
"Here is",
"Just a",
"Proxy description"
],
"matchCondition": {
"methods": [
"GET"
],
"route": "/ip"
},
"backendUri": "https://someapp.azurewebsites.net/api/ip"
}
}
}

And here is the schema definition:

  "properties": {
    "desc": {
      "type": "array",
      "items": {
        "type": "string"
      }
    },

@safihamid safihamid closed this Feb 27, 2018

@amadl

This comment has been minimized.

Copy link
Author

amadl commented Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.