Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2 cold start] Cache Expression compilation results during placeholder mode to avoid recompiles during specialization mode #4184

Closed
safihamid opened this Issue Mar 11, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@safihamid
Copy link
Contributor

safihamid commented Mar 11, 2019

This is accounting for ~50% of the cold start time in function host itself(~30% overall) across all languages.
Call stack here:

image

@safihamid safihamid self-assigned this Mar 11, 2019

safihamid added a commit that referenced this issue Mar 25, 2019

Fix for #4184
This change will improve cold starts by ~30% across the board for all languages.

Here are the numbers:

					percentile_Time_taken_50	percentile_Time_taken_80	percentile_Time_taken_90	percentile_Time_taken_95	percentile_Time_taken_99	avg_Time_taken	count_
Current cold start with placeholders	2032	2250	2359	2609	3422	2111.71276595745	94
Updated cold start with placeholders and optimization	1454	1579	1734	1906	2328	1483.76470588235	119
Current cold start without placeholders 	9500	10469	11062	11453	12406	9789.04	50
Updated cold start without placeholders and optimization	6985	7859	8734	8922	9765	7208.12	50

safihamid added a commit that referenced this issue Mar 25, 2019

Cold start Improvements for Functions
#4184

This change will improve cold starts by ~30% across the board for all languages.

Here are the numbers:

					percentile_Time_taken_50	percentile_Time_taken_80	percentile_Time_taken_90	percentile_Time_taken_95	percentile_Time_taken_99	avg_Time_taken	count_
Current cold start with placeholders	2032	2250	2359	2609	3422	2111.71276595745	94
Updated cold start with placeholders and optimization	1454	1579	1734	1906	2328	1483.76470588235	119
Current cold start without placeholders 	9500	10469	11062	11453	12406	9789.04	50
Updated cold start without placeholders and optimization	6985	7859	8734	8922	9765	7208.12	50

fabiocav added a commit that referenced this issue Mar 26, 2019

Cold start Improvements for Functions
#4184

This change will improve cold starts by ~30% across the board for all languages.

Here are the numbers:

					percentile_Time_taken_50	percentile_Time_taken_80	percentile_Time_taken_90	percentile_Time_taken_95	percentile_Time_taken_99	avg_Time_taken	count_
Current cold start with placeholders	2032	2250	2359	2609	3422	2111.71276595745	94
Updated cold start with placeholders and optimization	1454	1579	1734	1906	2328	1483.76470588235	119
Current cold start without placeholders 	9500	10469	11062	11453	12406	9789.04	50
Updated cold start without placeholders and optimization	6985	7859	8734	8922	9765	7208.12	50

safihamid added a commit that referenced this issue Mar 26, 2019

Cold start Improvements for Functions
#4184

This change will improve cold starts by ~30% across the board for all languages.

Here are the numbers:

					percentile_Time_taken_50	percentile_Time_taken_80	percentile_Time_taken_90	percentile_Time_taken_95	percentile_Time_taken_99	avg_Time_taken	count_
Current cold start with placeholders	2032	2250	2359	2609	3422	2111.71276595745	94
Updated cold start with placeholders and optimization	1454	1579	1734	1906	2328	1483.76470588235	119
Current cold start without placeholders 	9500	10469	11062	11453	12406	9789.04	50
Updated cold start without placeholders and optimization	6985	7859	8734	8922	9765	7208.12	50

brettsam added a commit that referenced this issue Apr 5, 2019

Cold start Improvements for Functions
#4184

This change will improve cold starts by ~30% across the board for all languages.

Here are the numbers:

					percentile_Time_taken_50	percentile_Time_taken_80	percentile_Time_taken_90	percentile_Time_taken_95	percentile_Time_taken_99	avg_Time_taken	count_
Current cold start with placeholders	2032	2250	2359	2609	3422	2111.71276595745	94
Updated cold start with placeholders and optimization	1454	1579	1734	1906	2328	1483.76470588235	119
Current cold start without placeholders 	9500	10469	11062	11453	12406	9789.04	50
Updated cold start without placeholders and optimization	6985	7859	8734	8922	9765	7208.12	50
@fabiocav

This comment has been minimized.

Copy link
Member

fabiocav commented Apr 10, 2019

Closing this as we'll no longer be taking this approach after the recent changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.