Remove partially installed snapshots #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnatoliB
requested review from
Francisco-Gamino,
SatishRanjan,
TylerLeonhardt and
daxian-dbw
Contributor
Francisco-Gamino
left a comment
Francisco-Gamino
left a comment
There was a problem hiding this comment.
One minor comment. Other than that, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If installing a managed dependencies snapshot fails for any reason, the current code just abandons the snapshot folder, relying on it to be eventually removed by regular purge. As a result, the partially installed snapshot keeps occupying file space, and prevents the next installation attempt from starting soon. There is no easy way to avoid these consequences when the PowerShell worker process is terminated. However, if the worker keeps running and it is aware of the installation attempt failure, it has an opportunity to perform the clean up sooner. This is what this PR achieves.