From 60e65d46d91d0f1f33b1f08d8cdae3d5e68edfab Mon Sep 17 00:00:00 2001 From: David Justo Date: Fri, 28 Jan 2022 19:20:04 -0800 Subject: [PATCH 1/4] separate DF SDK classes from DF worker classes fix typo remove TODOs remove commented-out code --- .../Actions/ActionType.cs | 0 .../Actions/CallActivityAction.cs | 0 .../Actions/CallActivityWithRetryAction.cs | 0 .../Actions/CreateDurableTimerAction.cs | 0 .../Actions/ExternalEventAction.cs | 0 .../Actions/OrchestrationAction.cs | 0 .../ActivityFailureException.cs | 0 .../Commands/InvokeDurableActivityCommand.cs | 4 ++-- .../Commands/SetDurableCustomStatusCommand.cs | 0 .../SetFunctionInvocationContextCommand.cs | 0 ...tartDurableExternalEventListenerCommand.cs | 0 .../Commands/StartDurableTimerCommand.cs | 0 .../Commands/StopDurableTimerTaskCommand.cs | 0 .../Commands/WaitDurableTaskCommand.cs | 0 .../CurrentUtcDateTimeUpdater.cs | 0 .../DurableActivityErrorHandler.cs | 0 .../DurableTaskHandler.cs | 0 src/{Durable => DurableSDK}/HistoryEvent.cs | 0 .../HistoryEventType.cs | 0 .../IOrchestrationInvoker.cs | 0 .../IPowerShellServices.cs | 0 .../OrchestrationActionCollector.cs | 0 .../OrchestrationBindingInfo.cs | 0 .../OrchestrationContext.cs | 0 .../OrchestrationFailureException.cs | 0 .../OrchestrationInvoker.cs | 0 .../OrchestrationMessage.cs | 0 .../PowerShellServices.cs | 0 src/{Durable => DurableSDK}/RetryOptions.cs | 0 src/{Durable => DurableSDK}/RetryProcessor.cs | 0 .../Tasks/ActivityInvocationTask.cs | 1 + .../Tasks/DurableTask.cs | 0 .../Tasks/DurableTimerTask.cs | 0 .../Tasks/ExternalEventTask.cs | 0 .../DurableBindings.cs | 2 +- .../DurableController.cs | 1 + .../DurableFunctionInfo.cs | 2 +- .../DurableFunctionInfoFactory.cs | 2 +- .../DurableFunctionType.cs | 2 +- src/FunctionInfo.cs | 2 +- src/RequestProcessor.cs | 2 +- test/E2E/TestFunctionApp/profile.ps1 | 22 +++++++++++++++++++ test/Unit/Durable/DurableControllerTests.cs | 1 + .../DurableFunctionInfoFactoryTests.cs | 2 +- .../Unit/PowerShell/PowerShellManagerTests.cs | 1 + 45 files changed, 35 insertions(+), 9 deletions(-) rename src/{Durable => DurableSDK}/Actions/ActionType.cs (100%) rename src/{Durable => DurableSDK}/Actions/CallActivityAction.cs (100%) rename src/{Durable => DurableSDK}/Actions/CallActivityWithRetryAction.cs (100%) rename src/{Durable => DurableSDK}/Actions/CreateDurableTimerAction.cs (100%) rename src/{Durable => DurableSDK}/Actions/ExternalEventAction.cs (100%) rename src/{Durable => DurableSDK}/Actions/OrchestrationAction.cs (100%) rename src/{Durable => DurableSDK}/ActivityFailureException.cs (100%) rename src/{Durable => DurableSDK}/Commands/InvokeDurableActivityCommand.cs (93%) rename src/{Durable => DurableSDK}/Commands/SetDurableCustomStatusCommand.cs (100%) rename src/{Durable => DurableSDK}/Commands/SetFunctionInvocationContextCommand.cs (100%) rename src/{Durable => DurableSDK}/Commands/StartDurableExternalEventListenerCommand.cs (100%) rename src/{Durable => DurableSDK}/Commands/StartDurableTimerCommand.cs (100%) rename src/{Durable => DurableSDK}/Commands/StopDurableTimerTaskCommand.cs (100%) rename src/{Durable => DurableSDK}/Commands/WaitDurableTaskCommand.cs (100%) rename src/{Durable => DurableSDK}/CurrentUtcDateTimeUpdater.cs (100%) rename src/{Durable => DurableSDK}/DurableActivityErrorHandler.cs (100%) rename src/{Durable => DurableSDK}/DurableTaskHandler.cs (100%) rename src/{Durable => DurableSDK}/HistoryEvent.cs (100%) rename src/{Durable => DurableSDK}/HistoryEventType.cs (100%) rename src/{Durable => DurableSDK}/IOrchestrationInvoker.cs (100%) rename src/{Durable => DurableSDK}/IPowerShellServices.cs (100%) rename src/{Durable => DurableSDK}/OrchestrationActionCollector.cs (100%) rename src/{Durable => DurableSDK}/OrchestrationBindingInfo.cs (100%) rename src/{Durable => DurableSDK}/OrchestrationContext.cs (100%) rename src/{Durable => DurableSDK}/OrchestrationFailureException.cs (100%) rename src/{Durable => DurableSDK}/OrchestrationInvoker.cs (100%) rename src/{Durable => DurableSDK}/OrchestrationMessage.cs (100%) rename src/{Durable => DurableSDK}/PowerShellServices.cs (100%) rename src/{Durable => DurableSDK}/RetryOptions.cs (100%) rename src/{Durable => DurableSDK}/RetryProcessor.cs (100%) rename src/{Durable => DurableSDK}/Tasks/ActivityInvocationTask.cs (98%) rename src/{Durable => DurableSDK}/Tasks/DurableTask.cs (100%) rename src/{Durable => DurableSDK}/Tasks/DurableTimerTask.cs (100%) rename src/{Durable => DurableSDK}/Tasks/ExternalEventTask.cs (100%) rename src/{Durable => DurableWorker}/DurableBindings.cs (95%) rename src/{Durable => DurableWorker}/DurableController.cs (98%) rename src/{Durable => DurableWorker}/DurableFunctionInfo.cs (92%) rename src/{Durable => DurableWorker}/DurableFunctionInfoFactory.cs (96%) rename src/{Durable => DurableWorker}/DurableFunctionType.cs (80%) create mode 100644 test/E2E/TestFunctionApp/profile.ps1 diff --git a/src/Durable/Actions/ActionType.cs b/src/DurableSDK/Actions/ActionType.cs similarity index 100% rename from src/Durable/Actions/ActionType.cs rename to src/DurableSDK/Actions/ActionType.cs diff --git a/src/Durable/Actions/CallActivityAction.cs b/src/DurableSDK/Actions/CallActivityAction.cs similarity index 100% rename from src/Durable/Actions/CallActivityAction.cs rename to src/DurableSDK/Actions/CallActivityAction.cs diff --git a/src/Durable/Actions/CallActivityWithRetryAction.cs b/src/DurableSDK/Actions/CallActivityWithRetryAction.cs similarity index 100% rename from src/Durable/Actions/CallActivityWithRetryAction.cs rename to src/DurableSDK/Actions/CallActivityWithRetryAction.cs diff --git a/src/Durable/Actions/CreateDurableTimerAction.cs b/src/DurableSDK/Actions/CreateDurableTimerAction.cs similarity index 100% rename from src/Durable/Actions/CreateDurableTimerAction.cs rename to src/DurableSDK/Actions/CreateDurableTimerAction.cs diff --git a/src/Durable/Actions/ExternalEventAction.cs b/src/DurableSDK/Actions/ExternalEventAction.cs similarity index 100% rename from src/Durable/Actions/ExternalEventAction.cs rename to src/DurableSDK/Actions/ExternalEventAction.cs diff --git a/src/Durable/Actions/OrchestrationAction.cs b/src/DurableSDK/Actions/OrchestrationAction.cs similarity index 100% rename from src/Durable/Actions/OrchestrationAction.cs rename to src/DurableSDK/Actions/OrchestrationAction.cs diff --git a/src/Durable/ActivityFailureException.cs b/src/DurableSDK/ActivityFailureException.cs similarity index 100% rename from src/Durable/ActivityFailureException.cs rename to src/DurableSDK/ActivityFailureException.cs diff --git a/src/Durable/Commands/InvokeDurableActivityCommand.cs b/src/DurableSDK/Commands/InvokeDurableActivityCommand.cs similarity index 93% rename from src/Durable/Commands/InvokeDurableActivityCommand.cs rename to src/DurableSDK/Commands/InvokeDurableActivityCommand.cs index ba9b429f..4868b62c 100644 --- a/src/Durable/Commands/InvokeDurableActivityCommand.cs +++ b/src/DurableSDK/Commands/InvokeDurableActivityCommand.cs @@ -43,10 +43,10 @@ protected override void EndProcessing() { var privateData = (Hashtable)MyInvocation.MyCommand.Module.PrivateData; var context = (OrchestrationContext)privateData[SetFunctionInvocationContextCommand.ContextKey]; - var loadedFunctions = FunctionLoader.GetLoadedFunctions(); + // var loadedFunctions = FunctionLoader.GetLoadedFunctions(); var task = new ActivityInvocationTask(FunctionName, Input, RetryOptions); - ActivityInvocationTask.ValidateTask(task, loadedFunctions); + // ActivityInvocationTask.ValidateTask(task, loadedFunctions); _durableTaskHandler.StopAndInitiateDurableTaskOrReplay( task, context, NoWait.IsPresent, diff --git a/src/Durable/Commands/SetDurableCustomStatusCommand.cs b/src/DurableSDK/Commands/SetDurableCustomStatusCommand.cs similarity index 100% rename from src/Durable/Commands/SetDurableCustomStatusCommand.cs rename to src/DurableSDK/Commands/SetDurableCustomStatusCommand.cs diff --git a/src/Durable/Commands/SetFunctionInvocationContextCommand.cs b/src/DurableSDK/Commands/SetFunctionInvocationContextCommand.cs similarity index 100% rename from src/Durable/Commands/SetFunctionInvocationContextCommand.cs rename to src/DurableSDK/Commands/SetFunctionInvocationContextCommand.cs diff --git a/src/Durable/Commands/StartDurableExternalEventListenerCommand.cs b/src/DurableSDK/Commands/StartDurableExternalEventListenerCommand.cs similarity index 100% rename from src/Durable/Commands/StartDurableExternalEventListenerCommand.cs rename to src/DurableSDK/Commands/StartDurableExternalEventListenerCommand.cs diff --git a/src/Durable/Commands/StartDurableTimerCommand.cs b/src/DurableSDK/Commands/StartDurableTimerCommand.cs similarity index 100% rename from src/Durable/Commands/StartDurableTimerCommand.cs rename to src/DurableSDK/Commands/StartDurableTimerCommand.cs diff --git a/src/Durable/Commands/StopDurableTimerTaskCommand.cs b/src/DurableSDK/Commands/StopDurableTimerTaskCommand.cs similarity index 100% rename from src/Durable/Commands/StopDurableTimerTaskCommand.cs rename to src/DurableSDK/Commands/StopDurableTimerTaskCommand.cs diff --git a/src/Durable/Commands/WaitDurableTaskCommand.cs b/src/DurableSDK/Commands/WaitDurableTaskCommand.cs similarity index 100% rename from src/Durable/Commands/WaitDurableTaskCommand.cs rename to src/DurableSDK/Commands/WaitDurableTaskCommand.cs diff --git a/src/Durable/CurrentUtcDateTimeUpdater.cs b/src/DurableSDK/CurrentUtcDateTimeUpdater.cs similarity index 100% rename from src/Durable/CurrentUtcDateTimeUpdater.cs rename to src/DurableSDK/CurrentUtcDateTimeUpdater.cs diff --git a/src/Durable/DurableActivityErrorHandler.cs b/src/DurableSDK/DurableActivityErrorHandler.cs similarity index 100% rename from src/Durable/DurableActivityErrorHandler.cs rename to src/DurableSDK/DurableActivityErrorHandler.cs diff --git a/src/Durable/DurableTaskHandler.cs b/src/DurableSDK/DurableTaskHandler.cs similarity index 100% rename from src/Durable/DurableTaskHandler.cs rename to src/DurableSDK/DurableTaskHandler.cs diff --git a/src/Durable/HistoryEvent.cs b/src/DurableSDK/HistoryEvent.cs similarity index 100% rename from src/Durable/HistoryEvent.cs rename to src/DurableSDK/HistoryEvent.cs diff --git a/src/Durable/HistoryEventType.cs b/src/DurableSDK/HistoryEventType.cs similarity index 100% rename from src/Durable/HistoryEventType.cs rename to src/DurableSDK/HistoryEventType.cs diff --git a/src/Durable/IOrchestrationInvoker.cs b/src/DurableSDK/IOrchestrationInvoker.cs similarity index 100% rename from src/Durable/IOrchestrationInvoker.cs rename to src/DurableSDK/IOrchestrationInvoker.cs diff --git a/src/Durable/IPowerShellServices.cs b/src/DurableSDK/IPowerShellServices.cs similarity index 100% rename from src/Durable/IPowerShellServices.cs rename to src/DurableSDK/IPowerShellServices.cs diff --git a/src/Durable/OrchestrationActionCollector.cs b/src/DurableSDK/OrchestrationActionCollector.cs similarity index 100% rename from src/Durable/OrchestrationActionCollector.cs rename to src/DurableSDK/OrchestrationActionCollector.cs diff --git a/src/Durable/OrchestrationBindingInfo.cs b/src/DurableSDK/OrchestrationBindingInfo.cs similarity index 100% rename from src/Durable/OrchestrationBindingInfo.cs rename to src/DurableSDK/OrchestrationBindingInfo.cs diff --git a/src/Durable/OrchestrationContext.cs b/src/DurableSDK/OrchestrationContext.cs similarity index 100% rename from src/Durable/OrchestrationContext.cs rename to src/DurableSDK/OrchestrationContext.cs diff --git a/src/Durable/OrchestrationFailureException.cs b/src/DurableSDK/OrchestrationFailureException.cs similarity index 100% rename from src/Durable/OrchestrationFailureException.cs rename to src/DurableSDK/OrchestrationFailureException.cs diff --git a/src/Durable/OrchestrationInvoker.cs b/src/DurableSDK/OrchestrationInvoker.cs similarity index 100% rename from src/Durable/OrchestrationInvoker.cs rename to src/DurableSDK/OrchestrationInvoker.cs diff --git a/src/Durable/OrchestrationMessage.cs b/src/DurableSDK/OrchestrationMessage.cs similarity index 100% rename from src/Durable/OrchestrationMessage.cs rename to src/DurableSDK/OrchestrationMessage.cs diff --git a/src/Durable/PowerShellServices.cs b/src/DurableSDK/PowerShellServices.cs similarity index 100% rename from src/Durable/PowerShellServices.cs rename to src/DurableSDK/PowerShellServices.cs diff --git a/src/Durable/RetryOptions.cs b/src/DurableSDK/RetryOptions.cs similarity index 100% rename from src/Durable/RetryOptions.cs rename to src/DurableSDK/RetryOptions.cs diff --git a/src/Durable/RetryProcessor.cs b/src/DurableSDK/RetryProcessor.cs similarity index 100% rename from src/Durable/RetryProcessor.cs rename to src/DurableSDK/RetryProcessor.cs diff --git a/src/Durable/Tasks/ActivityInvocationTask.cs b/src/DurableSDK/Tasks/ActivityInvocationTask.cs similarity index 98% rename from src/Durable/Tasks/ActivityInvocationTask.cs rename to src/DurableSDK/Tasks/ActivityInvocationTask.cs index 87bf61c2..fc3921cc 100644 --- a/src/Durable/Tasks/ActivityInvocationTask.cs +++ b/src/DurableSDK/Tasks/ActivityInvocationTask.cs @@ -16,6 +16,7 @@ namespace Microsoft.Azure.Functions.PowerShellWorker.Durable.Tasks using Microsoft.Azure.Functions.PowerShellWorker; using Microsoft.Azure.Functions.PowerShellWorker.Durable; using Microsoft.Azure.Functions.PowerShellWorker.Durable.Actions; + using Microsoft.Azure.Functions.PowerShellWorker.DurableWorker; public class ActivityInvocationTask : DurableTask { diff --git a/src/Durable/Tasks/DurableTask.cs b/src/DurableSDK/Tasks/DurableTask.cs similarity index 100% rename from src/Durable/Tasks/DurableTask.cs rename to src/DurableSDK/Tasks/DurableTask.cs diff --git a/src/Durable/Tasks/DurableTimerTask.cs b/src/DurableSDK/Tasks/DurableTimerTask.cs similarity index 100% rename from src/Durable/Tasks/DurableTimerTask.cs rename to src/DurableSDK/Tasks/DurableTimerTask.cs diff --git a/src/Durable/Tasks/ExternalEventTask.cs b/src/DurableSDK/Tasks/ExternalEventTask.cs similarity index 100% rename from src/Durable/Tasks/ExternalEventTask.cs rename to src/DurableSDK/Tasks/ExternalEventTask.cs diff --git a/src/Durable/DurableBindings.cs b/src/DurableWorker/DurableBindings.cs similarity index 95% rename from src/Durable/DurableBindings.cs rename to src/DurableWorker/DurableBindings.cs index 6bdf2468..d46a4adc 100644 --- a/src/Durable/DurableBindings.cs +++ b/src/DurableWorker/DurableBindings.cs @@ -3,7 +3,7 @@ // Licensed under the MIT license. See LICENSE file in the project root for full license information. // -namespace Microsoft.Azure.Functions.PowerShellWorker.Durable +namespace Microsoft.Azure.Functions.PowerShellWorker.DurableWorker { using System; diff --git a/src/Durable/DurableController.cs b/src/DurableWorker/DurableController.cs similarity index 98% rename from src/Durable/DurableController.cs rename to src/DurableWorker/DurableController.cs index 6b1f31bb..7b7f1b4e 100644 --- a/src/Durable/DurableController.cs +++ b/src/DurableWorker/DurableController.cs @@ -16,6 +16,7 @@ namespace Microsoft.Azure.Functions.PowerShellWorker.Durable using WebJobs.Script.Grpc.Messages; using PowerShellWorker.Utility; + using Microsoft.Azure.Functions.PowerShellWorker.DurableWorker; /// /// The main entry point for durable functions support. diff --git a/src/Durable/DurableFunctionInfo.cs b/src/DurableWorker/DurableFunctionInfo.cs similarity index 92% rename from src/Durable/DurableFunctionInfo.cs rename to src/DurableWorker/DurableFunctionInfo.cs index a245ac67..8665cfe8 100644 --- a/src/Durable/DurableFunctionInfo.cs +++ b/src/DurableWorker/DurableFunctionInfo.cs @@ -3,7 +3,7 @@ // Licensed under the MIT license. See LICENSE file in the project root for full license information. // -namespace Microsoft.Azure.Functions.PowerShellWorker.Durable +namespace Microsoft.Azure.Functions.PowerShellWorker.DurableWorker { internal class DurableFunctionInfo { diff --git a/src/Durable/DurableFunctionInfoFactory.cs b/src/DurableWorker/DurableFunctionInfoFactory.cs similarity index 96% rename from src/Durable/DurableFunctionInfoFactory.cs rename to src/DurableWorker/DurableFunctionInfoFactory.cs index 3e65b9f7..0cc08d27 100644 --- a/src/Durable/DurableFunctionInfoFactory.cs +++ b/src/DurableWorker/DurableFunctionInfoFactory.cs @@ -3,7 +3,7 @@ // Licensed under the MIT license. See LICENSE file in the project root for full license information. // -namespace Microsoft.Azure.Functions.PowerShellWorker.Durable +namespace Microsoft.Azure.Functions.PowerShellWorker.DurableWorker { using System.Linq; diff --git a/src/Durable/DurableFunctionType.cs b/src/DurableWorker/DurableFunctionType.cs similarity index 80% rename from src/Durable/DurableFunctionType.cs rename to src/DurableWorker/DurableFunctionType.cs index 73feb504..2ecacc17 100644 --- a/src/Durable/DurableFunctionType.cs +++ b/src/DurableWorker/DurableFunctionType.cs @@ -3,7 +3,7 @@ // Licensed under the MIT license. See LICENSE file in the project root for full license information. // -namespace Microsoft.Azure.Functions.PowerShellWorker.Durable +namespace Microsoft.Azure.Functions.PowerShellWorker.DurableWorker { internal enum DurableFunctionType { diff --git a/src/FunctionInfo.cs b/src/FunctionInfo.cs index 2aea62ec..091eecde 100644 --- a/src/FunctionInfo.cs +++ b/src/FunctionInfo.cs @@ -15,7 +15,7 @@ namespace Microsoft.Azure.Functions.PowerShellWorker { - using Durable; + using DurableWorker; /// /// This type represents the metadata of an Azure PowerShell Function. diff --git a/src/RequestProcessor.cs b/src/RequestProcessor.cs index 6aabd3f3..93a1271f 100644 --- a/src/RequestProcessor.cs +++ b/src/RequestProcessor.cs @@ -13,7 +13,7 @@ using Microsoft.Azure.Functions.PowerShellWorker.PowerShell; using Microsoft.Azure.Functions.PowerShellWorker.Utility; using Microsoft.Azure.Functions.PowerShellWorker.DependencyManagement; -using Microsoft.Azure.Functions.PowerShellWorker.Durable; +using Microsoft.Azure.Functions.PowerShellWorker.DurableWorker; using Microsoft.Azure.WebJobs.Script.Grpc.Messages; namespace Microsoft.Azure.Functions.PowerShellWorker diff --git a/test/E2E/TestFunctionApp/profile.ps1 b/test/E2E/TestFunctionApp/profile.ps1 new file mode 100644 index 00000000..9afdf1da --- /dev/null +++ b/test/E2E/TestFunctionApp/profile.ps1 @@ -0,0 +1,22 @@ +# Azure Functions profile.ps1 +# +# This profile.ps1 will get executed every "cold start" of your Function App. +# "cold start" occurs when: +# +# * A Function App starts up for the very first time +# * A Function App starts up after being de-allocated due to inactivity +# +# You can define helper functions, run commands, or specify environment variables +# NOTE: any variables defined that are not environment variables will get reset after the first execution + +# Authenticate with Azure PowerShell using MSI. +# Remove this if you are not planning on using MSI or Azure PowerShell. +if ($env:MSI_SECRET) { + Disable-AzContextAutosave -Scope Process | Out-Null + Connect-AzAccount -Identity +} + +# Uncomment the next line to enable legacy AzureRm alias in Azure PowerShell. +# Enable-AzureRmAlias + +# You can also define functions or aliases that can be referenced in any of your PowerShell functions. \ No newline at end of file diff --git a/test/Unit/Durable/DurableControllerTests.cs b/test/Unit/Durable/DurableControllerTests.cs index 68531f7c..5ec3244c 100644 --- a/test/Unit/Durable/DurableControllerTests.cs +++ b/test/Unit/Durable/DurableControllerTests.cs @@ -11,6 +11,7 @@ namespace Microsoft.Azure.Functions.PowerShellWorker.Test.Durable using System.Collections.ObjectModel; using Microsoft.Azure.WebJobs.Script.Grpc.Messages; + using Microsoft.Azure.Functions.PowerShellWorker.DurableWorker; using Microsoft.Azure.Functions.PowerShellWorker.Durable; using Microsoft.Azure.Functions.PowerShellWorker.Utility; using Newtonsoft.Json; diff --git a/test/Unit/Durable/DurableFunctionInfoFactoryTests.cs b/test/Unit/Durable/DurableFunctionInfoFactoryTests.cs index 09cea266..2c898316 100644 --- a/test/Unit/Durable/DurableFunctionInfoFactoryTests.cs +++ b/test/Unit/Durable/DurableFunctionInfoFactoryTests.cs @@ -10,7 +10,7 @@ namespace Microsoft.Azure.Functions.PowerShellWorker.Test.Durable using Xunit; - using Microsoft.Azure.Functions.PowerShellWorker.Durable; + using Microsoft.Azure.Functions.PowerShellWorker.DurableWorker; public class DurableFunctionInfoFactoryTests { diff --git a/test/Unit/PowerShell/PowerShellManagerTests.cs b/test/Unit/PowerShell/PowerShellManagerTests.cs index 5d4faf42..36588611 100644 --- a/test/Unit/PowerShell/PowerShellManagerTests.cs +++ b/test/Unit/PowerShell/PowerShellManagerTests.cs @@ -18,6 +18,7 @@ namespace Microsoft.Azure.Functions.PowerShellWorker.Test using System.Collections.ObjectModel; using System.Management.Automation; using Microsoft.Azure.Functions.PowerShellWorker.Durable; + using Microsoft.Azure.Functions.PowerShellWorker.DurableWorker; using Newtonsoft.Json; internal class TestUtils From dd2d61d08b20a28283287165c7be9b19451c7eca Mon Sep 17 00:00:00 2001 From: David Justo Date: Thu, 7 Apr 2022 16:05:46 -0700 Subject: [PATCH 2/4] restore activity validation logic --- src/DurableSDK/Commands/InvokeDurableActivityCommand.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DurableSDK/Commands/InvokeDurableActivityCommand.cs b/src/DurableSDK/Commands/InvokeDurableActivityCommand.cs index 4868b62c..ba9b429f 100644 --- a/src/DurableSDK/Commands/InvokeDurableActivityCommand.cs +++ b/src/DurableSDK/Commands/InvokeDurableActivityCommand.cs @@ -43,10 +43,10 @@ protected override void EndProcessing() { var privateData = (Hashtable)MyInvocation.MyCommand.Module.PrivateData; var context = (OrchestrationContext)privateData[SetFunctionInvocationContextCommand.ContextKey]; - // var loadedFunctions = FunctionLoader.GetLoadedFunctions(); + var loadedFunctions = FunctionLoader.GetLoadedFunctions(); var task = new ActivityInvocationTask(FunctionName, Input, RetryOptions); - // ActivityInvocationTask.ValidateTask(task, loadedFunctions); + ActivityInvocationTask.ValidateTask(task, loadedFunctions); _durableTaskHandler.StopAndInitiateDurableTaskOrReplay( task, context, NoWait.IsPresent, From fd3c6020f918953144417f83f12095b2ece0e563 Mon Sep 17 00:00:00 2001 From: David Justo Date: Thu, 7 Apr 2022 16:12:04 -0700 Subject: [PATCH 3/4] add release_notes --- release_notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release_notes.md b/release_notes.md index c636147d..900ff3e5 100644 --- a/release_notes.md +++ b/release_notes.md @@ -1 +1 @@ -* Bug fix: Activity Functions can now use output bindings (https://github.com/Azure/azure-functions-powershell-worker/issues/646) \ No newline at end of file +* New feature: The `Get-TaskResult` CmdLet can now be used to get the result of already completed DF Tasks! Thanks @oobegreg for your contribution! \ No newline at end of file From f734cf264aef0da874755565559841d4c74035b7 Mon Sep 17 00:00:00 2001 From: David Justo Date: Mon, 18 Apr 2022 11:09:24 -0700 Subject: [PATCH 4/4] delete auto-gen profile.ps1 in E2E test --- test/E2E/TestFunctionApp/profile.ps1 | 22 ---------------------- 1 file changed, 22 deletions(-) delete mode 100644 test/E2E/TestFunctionApp/profile.ps1 diff --git a/test/E2E/TestFunctionApp/profile.ps1 b/test/E2E/TestFunctionApp/profile.ps1 deleted file mode 100644 index 9afdf1da..00000000 --- a/test/E2E/TestFunctionApp/profile.ps1 +++ /dev/null @@ -1,22 +0,0 @@ -# Azure Functions profile.ps1 -# -# This profile.ps1 will get executed every "cold start" of your Function App. -# "cold start" occurs when: -# -# * A Function App starts up for the very first time -# * A Function App starts up after being de-allocated due to inactivity -# -# You can define helper functions, run commands, or specify environment variables -# NOTE: any variables defined that are not environment variables will get reset after the first execution - -# Authenticate with Azure PowerShell using MSI. -# Remove this if you are not planning on using MSI or Azure PowerShell. -if ($env:MSI_SECRET) { - Disable-AzContextAutosave -Scope Process | Out-Null - Connect-AzAccount -Identity -} - -# Uncomment the next line to enable legacy AzureRm alias in Azure PowerShell. -# Enable-AzureRmAlias - -# You can also define functions or aliases that can be referenced in any of your PowerShell functions. \ No newline at end of file