Add constructors to SignalRMessage and SignalRGroupAction #53
Conversation
| * @param target Target method to invoke on clients | ||
| * @param arguments Arguments to pass to target method | ||
| */ | ||
| public SignalRMessage(String target, Object... arguments) { |
There was a problem hiding this comment.
public SignalRMessage( [](start = 4, length = 22)
Shall we also add one contractor with userId that for send to user and one contractor with groupname that for send to group? #Resolved
There was a problem hiding this comment.
There was a problem hiding this comment.
Been thinking about this one. Because they are both String, I'm not sure how we can differentiate. Potentially, we can remove userId and groupName from SignalRMessage and create subclasses SignalRGroupMessage and SignalRUserMessage that have those as fields and in the constructors. This is probably a better way to do it, but might be too late to make this big of a change. #Resolved
There was a problem hiding this comment.
Yes. I'm thinking if it should be handled in app level or function level. It's not block issue. Let's consider it in next releasing cycle.
In reply to: 261930864 [](ancestors = 261930864)
| */ | ||
| public SignalRMessage(String target, Object... arguments) { | ||
| this.target = target; | ||
| this.arguments.addAll(Arrays.asList(arguments)); |
There was a problem hiding this comment.
* ignore global.json to unblock local build (#52) * add java scm for release required * Add constructors to SignalRMessage and SignalRGroupAction (#53) * Add constructors * Change to use .addAll * Add Azure Java Function simple-chat sample (#49) * add java simple-chat sample * Update version info * update CORS to enable visit test site from file * Fix sample function serialize issue. * update extension reference to GA version * test use (will revert before check-in) * remove reference SNAPSHOT * allow telemetry * update function with class constructor changes * use real plugin repositories * Wanl/use mng sdk (#57) * Update to the correct version for the extension (#60) * add user's claims to azure signalr access token (#61) * README.md Update - Removed the groups point under Current Limitations (#55) * Removed the groups point under Current Limitation in README.md * Update support scenario and limitation in README * Exposing servicehubcontext for improving user experience (#62) * update version (#64)
Make it easier to instantiate these objects properly.
The text was updated successfully, but these errors were encountered: