Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"IoTHubRegistryManager_GetDeviceList" is deprecated. #640

Closed
ahidaka opened this issue Sep 17, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@ahidaka
Copy link

commented Sep 17, 2018

  • OS and version used: Ubuntu 16.04, 18.04, etc...

  • SDK version used: azure-iot-sdk-c 1.2.9

Description of the issue:

"IoTHubRegistryManager_GetDeviceList" is deprecated and may be removed from a future release.
Which API shall I use to get list of all device list instead of this? This is not described anywhere.

Code sample exhibiting the issue:

Those are related code and documents below in SDK.

  • iothub_service_client/devdoc/requirement_docs/iothubserviceclient_registrymanager_requirements.md
  • iothub_service_client/src/iothub_service_client.def
  • iothub_service_client/src/iothub_registrymanager.c
  • iothub_service_client/tests/iothub_rm_ut/iothub_rm_ut.c
  • iothub_service_client/inc/iothub_registrymanager.h

Console log of the issue:

@ahidaka

This comment has been minimized.

Copy link
Author

commented Sep 17, 2018

I found the fact that should be IoTHubRegistryManager_GetModuleOrDeviceList().
Is this correct?

@ahidaka

This comment has been minimized.

Copy link
Author

commented Sep 17, 2018

OK, I found IoTHubRegistryManager_GetModuleOrDeviceList() doesn't work.
Is there any way to get the list of devices?

@massand massand self-assigned this Oct 1, 2018

@massand

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2018

@ahidaka IoTHubRegistryManager_GetModuleOrDeviceList is an internal API (not exposed by the SDK for external consumption). IoTHubRegistryManager_GetDeviceList can be used externally at the moment, until it is deprecated, but it has a max limit of 1000 devices due to the nature of the REST API it calls.

If you would like better support for device query, I recommend using the C# SDK service client's CreateQuery call to achieve supported service client functionality.

@massand massand closed this Oct 2, 2018

@az-iot-builder-01

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2018

@ahidaka, @massand, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey

@ahidaka

This comment has been minimized.

Copy link
Author

commented Oct 10, 2018

OK, now I'm checking that IoTHubRegistryManager_GetDeviceList doesn't work only for one device with Segmentation fault, not 1000 devices. I forgot to tell this problem. I will create new issue for this.

@ahidaka

This comment has been minimized.

Copy link
Author

commented Oct 23, 2018

Thanks for your advice. I confirmed "IoTHubRegistryManager_GetDeviceList" is working well.
Please don't deprecate "IoTHubRegistryManager_GetDeviceList".
I send the pull request for new samples with this. It will help iothub-explorer retire.

@ahidaka ahidaka referenced this issue Oct 23, 2018

Closed

modify to accept commands and options #690

0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.