fix (client): Add ability to locally close connection on timeout #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamdavi
requested review from
abhipsaMisra,
azabbasi,
brycewang-microsoft,
drwill-ms and
timtay-microsoft
as code owners
drwill-ms
approved these changes
Jan 11, 2022
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
timtay-microsoft
approved these changes
Jan 11, 2022
azabbasi
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the IoT Hub client times out for a keep alive, usually it will send a close packet which will be acknowledged by the client and gracefully shut down the connection. In some cases if the TCP socket is unresponsive but not yet closed it will cause the Close packet to be lost and the client will hang indefinitely.
This change allows for us to check to see if the connection has been closed by proton-j and call our local close methods to allow the client and customer to react to this situation.