Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #560 - bug in Device.Client#close() #561

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@kartben
Copy link
Contributor

commented May 20, 2019

Call super.close() with proper callback to fix the behavior when Device.Client#close() is called with no callback (e.g when callers expects to get a Promise)

Checklist

Reference/Link to the issue solved with this PR (if any)

Fixes issue #560

Description of the problem

Description of the solution

Fix for #560 - bug in Device.Client#close()
Call super.close() with proper callback to fix the behavior when Device.Client#close() is called with no callback (e.g when callers expects to get a Promise)
@anthonyvercolano
Copy link
Contributor

left a comment

:shipit:

@anthonyvercolano

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Carried over by #561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.