Skip to content

fix(azure-iot-device): Removed SasTokenRenewalStage from HTTPPipeline #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2020
Merged

fix(azure-iot-device): Removed SasTokenRenewalStage from HTTPPipeline #583

merged 3 commits into from
Jun 8, 2020

Conversation

@cartertinney
Copy link
Member

@cartertinney cartertinney commented May 30, 2020

  • Fixed double renewal problem (HTTP/MQTT pipeline both renewing token)
  • By convention, HTTP pipeline is now dependent on the parallel MQTTPipeline to ensure that the SasToken in the PipelineConfig is always valid
  • Consider changing this design at a later date if necesary

BertKleewein
BertKleewein approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@BertKleewein BertKleewein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cartertinney cartertinney merged commit 80c0dd4 into Azure:master Jun 8, 2020
@cartertinney cartertinney deleted the ct-remove-http-sas-renewal branch January 13, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olivakar olivakar olivakar approved these changes

@BertKleewein BertKleewein BertKleewein approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cartertinney @olivakar @BertKleewein @jebrando