Inconsistent formatting of Guid primary keys #215

Closed
migig opened this Issue Aug 29, 2016 · 0 comments

Projects

None yet

3 participants

@migig
migig commented Aug 29, 2016

On the server, a PK is created as such:

Guid.NewGuid().ToString("N");

On the client, a PK is created as such:

Guid.NewGuid().ToString();

So it may, or may not, have hyphens.

I'm not a database expert, but common sense tells me the hyphens would slow down a query over a very large table.

And even if not so, this has caused us some problems when we deal with PKs in our system, we need to first clean them.

Unless this is because of some weird implementation detail that I don't understand, please consider fixing it so it is consistent. Preferably without hyphens.

@adrianhall adrianhall added this to the Managed-Client 3.1.0 milestone Sep 12, 2016
@adrianhall adrianhall self-assigned this Oct 11, 2016
@adrianhall adrianhall removed their assignment Nov 16, 2016
@adrianhall adrianhall added a commit to adrianhall/azure-mobile-apps-net-client that referenced this issue Jan 4, 2017
@adrianhall adrianhall (#215) Added formatter to NewGuid.ToString() 8a96ca5
@adrianhall adrianhall self-assigned this Jan 4, 2017
@pvbchak pvbchak closed this in #273 Jan 5, 2017
@pvbchak pvbchak removed the in progress label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment