Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Tag copy #162

Closed
mbharodia opened this issue Oct 3, 2016 · 2 comments
Closed

Missing Tag copy #162

mbharodia opened this issue Oct 3, 2016 · 2 comments
Assignees

Comments

@mbharodia
Copy link

@mbharodia mbharodia commented Oct 3, 2016

azure-mobile-apps-net-server/src/Microsoft.Azure.Mobile.Server.Notifications/Controllers/NotificationInstallationsController.cs

at line 18

"Installation" type is generated from "NotificationInstallation". This method, looks like that, does not copy "Tags" property from "NotificationInstallation".

Please check. If I am missing something, then please let me know and accept my apology.

I am using this package and it does not copy tags. I was locating a problem and I am not able to find anything except this method where there is no code to copy "Tags" supplied in "NotificationInstallation" object.

@mbharodia
Copy link
Author

@mbharodia mbharodia commented Oct 3, 2016

Please read line 82 instead of 18

@adrianhall
Copy link
Member

@adrianhall adrianhall commented Nov 2, 2016

We explicitly do not allow tags in the registration service. Use the App Service Push registration endpoint instead, as that allows tags.

@adrianhall adrianhall closed this Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.