Skip to content

Conversation

@idear1203
Copy link
Contributor

add AzureSynapseServiceEndpointSuffix and AzureSynapseServiceEndpointResourceId for Azure Synapse Analytics

@idear1203 idear1203 changed the title Add Synapse service endpoint Add Azure Synapse Analytics endpoint Mar 2, 2020
@isra-fel isra-fel self-assigned this Mar 2, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit a4e7f52 into Azure:master Mar 23, 2020
@isra-fel
Copy link
Member

isra-fel commented Mar 23, 2020

Hi, here's the suggestion on the following things:

  1. Build signed package: https://dev.azure.com/azure-sdk/internal/_build?definitionId=700
  2. Put signed package in azure-powershell/tools/LocalFeed
  3. Edit .\tools\Common.Netcore.Dependencies.targets , change the version to all common libs to the version of signed package
  4. Develop azure powershell on top of local package, and when it's ready, submit a PR
  5. When the PR is ready to merge, we'll build and publish a new version of common libs. Update your references and delete local packages.
  6. We merge the PR

@idear1203
Copy link
Contributor Author

Hi, here's the suggestion on the following things:

  1. Build signed package: https://dev.azure.com/azure-sdk/internal/_build?definitionId=700
  2. Put signed package in azure-powershell/tools/LocalFeed
  3. Edit .\tools\Common.Netcore.Dependencies.targets , change the version to all common libs to the version of signed package
  4. Develop azure powershell on top of local package, and when it's ready, submit a PR
  5. When the PR is ready to merge, we'll build and publish a new version of common libs. Update your references and delete local packages.
  6. We merge the PR

Thanks for the detailed steps! I will follow the instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants