Skip to content

Conversation

@isra-fel
Copy link
Member

@isra-fel isra-fel commented Aug 24, 2021

Adding APIs to well-known types (IAzureContextContainer in this case) is risky as:

  • It is a binary breaking change - what if someone implements the interface in their own code
  • It is harder not to introduce breaking change the bigger the interface grows.

So, we came up with a pattern to avoid touching IAzureContextContainer, using ComponentRegistery.
Related powershell PR: Azure/azure-powershell#15743

@isra-fel isra-fel changed the title Do not add api to IAzureContextContainer Undo adding new API to IAzureContextContainer Aug 24, 2021
@isra-fel isra-fel marked this pull request as ready for review August 24, 2021 15:32
@VeryEarly VeryEarly merged commit 6672e47 into main Aug 25, 2021
@VeryEarly VeryEarly deleted the yeming/no-public-api branch August 25, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants