Common test controller framework #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix reference versions
# Conflicts: # Azure.PowerShell.Common.Netcore.sln
…erShell in assembly name;
…rshell-common into test-controller
…ioTest, ScenarioTest.ResourceManager, and TestFx no longer place xunit/MSTest files into their package content directory. This was a bug from the net452 targets files change.
MiYanni
commented
Sep 28, 2018
markcowl
previously requested changes
Oct 8, 2018
Member
markcowl
left a comment
markcowl
left a comment
There was a problem hiding this comment.
This looks good - one question and one comment - also, please address Yanni's comments
cormacpayne
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 6180