Add live only tests to enable authentication debugging #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiYanni
requested changes
Aug 30, 2018
Contributor
MiYanni
left a comment
MiYanni
left a comment
There was a problem hiding this comment.
Minor change. But, looks generally good, as long as the build is passing.
Contributor
|
@cormacpayne The failure is: |
cormacpayne
force-pushed
the
add-live-only-test
branch
from
a637109 to
0360206
Compare
cormacpayne
force-pushed
the
add-live-only-test
branch
from
e1b2391 to
88fd893
Compare
MiYanni
approved these changes
Aug 31, 2018
Contributor
MiYanni
left a comment
MiYanni
left a comment
There was a problem hiding this comment.
LGTM. The more tests, the merrier! 🎄
MiYanni
requested changes
Aug 31, 2018
Contributor
MiYanni
left a comment
MiYanni
left a comment
There was a problem hiding this comment.
Add notes to README.md for Authentication.Test on how to use the live login tests.
MiYanni
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce two new tests,
LoginWithUsernameAndPasswordandLoginWithServicePrincipal, that allow users to debug runningConnect-AzAccountin the common repository.Also adding
Authentication.Test.Netcoreproject to .NET Core solution, so this PR resolves some errors that resulted from this.