Support in-tool notification for version upgrade #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Nickcandy
previously approved these changes
Jul 24, 2023
BethanyZhou
suggested changes
Jul 24, 2023
Comment on lines
+250
to
+252
| if (result != null && result.Count > 0) | ||
| { | ||
| output.AddRange(result); |
Contributor
There was a problem hiding this comment.
Please check $LASTEXITCODE before adding result to output, here is an example.
wyunchi-ms
reviewed
Jul 24, 2023
src/Common/IFrequencyService.cs
Outdated
| /// Adds the specified feature to the service's per-PSsession registry. | ||
| /// </summary> | ||
| /// <param name="featureName">The name of the feature to add.</param> | ||
| void AddSession(string featureName); |
Contributor
There was a problem hiding this comment.
I think Add maybe more clear. Also I'm curious whether if we want to support other frequency such as every 30 execution.
Contributor
Author
There was a problem hiding this comment.
It's not in the scope for now. But it could be added later.
BethanyZhou
approved these changes
Jul 24, 2023
Nickcandy
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will prompt a warning message to the user if local Azure PowerShell module versions are not the latest.
Refer to the design spec for details.
It'll work together with Azure/azure-powershell#22338.
The warning message examples:
