Skip to content

Conversation

@MattiasAng
Copy link
Contributor

Description

Documentation added to missing parameter.

Checklist

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@msftclas
Copy link

msftclas commented Sep 19, 2019

CLA assistant check
All CLA requirements met.

@wyunchi-ms
Copy link
Contributor

wyunchi-ms commented Sep 20, 2019

Hi @MattiasAng. Thanks for your contribution!

  1. The example is great.
  2. As the type of Include is IncludeOptionsEnum so the introduction of the parameters should provide the allowed values in the enum. The script that generate the help document will fill this automatically. Please generate the help document of the interface but not by hand. Here is the guide for the help generating generating-help

@markcowl
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. In order to release this update, we ask that you add a short entry to the Changelog.MD in src\ResourceGraph\ResourceGraph Can you please add an entry there?

@markcowl
Copy link
Member

markcowl commented Oct 1, 2019

@demyanenko Can you review this contribution?

@ilidemi
Copy link

ilidemi commented Oct 1, 2019

@OlhaTkachenko Can you please review?

@OlhaTkachenko
Copy link

Looks good for me!
@MattiasAng, thank you for adding it

wyunchi-ms
wyunchi-ms previously approved these changes Oct 22, 2019
@isra-fel
Copy link
Member

isra-fel commented Nov 5, 2019

@wyunchi-ms could you add the readme entry for the contributor? Thanks!

@isra-fel isra-fel assigned wyunchi-ms and unassigned OlhaTkachenko Nov 5, 2019
@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants