From c0db613c8538184855e6b96a0ee29e43cee0de07 Mon Sep 17 00:00:00 2001 From: "Erich(Renyong) Wang" Date: Thu, 31 Oct 2019 15:59:18 +0800 Subject: [PATCH] add pr knowledge share doc --- .../pull-request-review-knowledge-share.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 documentation/internal/pull-request-review-knowledge-share.md diff --git a/documentation/internal/pull-request-review-knowledge-share.md b/documentation/internal/pull-request-review-knowledge-share.md new file mode 100644 index 000000000000..14db0a3d3635 --- /dev/null +++ b/documentation/internal/pull-request-review-knowledge-share.md @@ -0,0 +1,15 @@ +## PR Review Knowledge Share + +### Dependency Assemlby Version Confliction +If one assembly has been referenced by more than one module, we should let Az.Accounts to handle the dependency. + +**RED** flag +- Update assembly version for common Microsoft.Extensions.* +- Add new dependency assemlby for one module, the assembly may be referenced by other module already. +- Contains version update for dependency assembly in module other than Az.Accounts + +### Resource ID **MUST** start with a slash +*Correct*: "/subscriptions/18bxxxxxx-4d70-8b1e-937660bde798/resourceGroups/MNC-PowerShell/providers/Microsoft.Network/virtualnetworks/Mesh1" + +*Wrong*: "subscriptions/18bxxxxxx-92e4-4d70-8b1e-937660bde798/resourceGroups/MNC-PowerShell/providers/Microsoft.Network/virtualnetworks/Mesh1" +