-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Add exclusions to WAF cmdlets #10507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @digavino readme.md needs to be updated
src/FrontDoor/FrontDoor/Cmdlets/NewAzureRmFrontDoorFrontendEndpointObject.cs
Outdated
Show resolved
Hide resolved
src/FrontDoor/FrontDoor/Cmdlets/EnableAzureRmFrontDoorCustomDomainHttps.cs
Show resolved
Hide resolved
|
@digavino please change the PR's title and description properly. You are doing much more than just upgrading SDK version. And also make sure to read and check the checklist please. Thanks |
…to frontdoor-sdk-upgrade
|
Hi, now the code review is ready (no unrelated changes). Thanks @isra-fel |
…to frontdoor-sdk-upgrade
…to frontdoor-sdk-upgrade
Description
Adding Exclusion parameter to WAF cmdlets.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added