Skip to content

Conversation

@digavino
Copy link
Contributor

@digavino digavino commented Nov 8, 2019

Description

Adding Exclusion parameter to WAF cmdlets.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel self-assigned this Nov 11, 2019
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @digavino readme.md needs to be updated

@isra-fel
Copy link
Member

@digavino please change the PR's title and description properly. You are doing much more than just upgrading SDK version.

And also make sure to read and check the checklist please.

Thanks

@digavino digavino changed the title Upgrade SDK package to latest version Add exclusions to WAF cmdlets Nov 15, 2019
eschwabe
eschwabe previously approved these changes Nov 19, 2019
@digavino
Copy link
Contributor Author

Hi, now the code review is ready (no unrelated changes). Thanks @isra-fel

@isra-fel isra-fel assigned isra-fel and unassigned digavino Nov 20, 2019
@digavino digavino requested a review from isra-fel November 21, 2019 21:27
@digavino digavino requested a review from isra-fel November 25, 2019 19:22
@isra-fel isra-fel merged commit 6c499ec into master Nov 27, 2019
@dingmeng-xue dingmeng-xue deleted the frontdoor-sdk-upgrade branch May 13, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants