Skip to content

Conversation

@ksaaf
Copy link

@ksaaf ksaaf commented Nov 26, 2019

Description

Added support to specify the Curve for Certificate Policies [Issue: 9241]

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly self-assigned this Nov 27, 2019
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@ksaaf
Copy link
Author

ksaaf commented Nov 27, 2019

@VeryEarly
I see this PR (#10612) is merged to master. I also see another PR (#10617) for reverting this merge.

What's the reason for the other PR?

Thanks!

@VeryEarly
Copy link
Collaborator

VeryEarly commented Nov 28, 2019

@VeryEarly
I see this PR (#10612) is merged to master. I also see another PR (#10617) for reverting this merge.

What's the reason for the other PR?

Thanks!

I was thinking someone from key vault team should also take a look at your pr because I'm not that familiar with this module, kept this revert pr as backup.

@ksaaf
Copy link
Author

ksaaf commented Dec 5, 2019

@VeryEarly
I see this PR (#10612) is merged to master. I also see another PR (#10617) for reverting this merge.
What's the reason for the other PR?
Thanks!

I was thinking someone from key vault team should also take a look at your pr because I'm not that familiar with this module, kept this revert pr as backup.

@VeryEarly
I am from the Azure Key Vault team. Do you need any additional sign off?

@VeryEarly
Copy link
Collaborator

@VeryEarly
I see this PR (#10612) is merged to master. I also see another PR (#10617) for reverting this merge.
What's the reason for the other PR?
Thanks!

I was thinking someone from key vault team should also take a look at your pr because I'm not that familiar with this module, kept this revert pr as backup.

@VeryEarly
I am from the Azure Key Vault team. Do you need any additional sign off?

Hi @kashifm-msft ,

We're good now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants