Skip to content

Conversation

@hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Jan 10, 2020

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/457

  • Add Update-AzDiskEncryptionSet cmdlet
  • Add EncryptionType and DiskEncryptionSetId parameter to New-AzDiskUpdateConfig and New-AzSnapshotUpdateConfig

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Copy link
Member

@erich-wang erich-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyonholee , just one minor comment, please address it and I'll merge it, thanks.

…yptionSetId parameter to New-AzDiskUpdateConfig and New-AzSnapshotUpdateConfig
@erich-wang erich-wang merged commit c9ab224 into Azure:master Jan 10, 2020
@hyonholee hyonholee deleted the encryption branch January 17, 2020 19:54
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants