[Express Route] IPv6 Global Reach Add/Set-AzExpressRouteCircuitConnection cmdlet changes. #10912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updated help text in documentation.
amwate
requested review from
MikhailTryakhov,
VeryEarly,
anton-evseev,
dedhar,
isra-fel,
markcowl,
nagula-ritvika,
njuCZ and
v-shhatt
and removed request for
MikhailTryakhov,
dedhar,
nagula-ritvika,
njuCZ and
v-shhatt
isra-fel
requested changes
Jan 25, 2020
...twork/ExpressRouteCircuit/Peering/Connection/AzureExpressRouteCircuitConnectionConfigBase.cs
Outdated
Show resolved
Hide resolved
...ExpressRouteCircuit/Peering/Connection/SetAzureExpressRouteCircuitConnectionConfigCommand.cs
Show resolved
Hide resolved
src/Network/Network/help/Add-AzExpressRouteCircuitConnectionConfig.md
Outdated
Show resolved
Hide resolved
| ``` | ||
| Add-AzExpressRouteCircuitConnectionConfig [-Name] <String> [-ExpressRouteCircuit] <PSExpressRouteCircuit> | ||
| [-PeerExpressRouteCircuitPeering] <String> [-AddressPrefix] <String> [-AuthorizationKey <String>] | ||
| [-PeerExpressRouteCircuitPeering] <String> [-AddressPrefix] <String> -[AddressPrefixType] <String> [-AuthorizationKey <String>] |
src/Network/Network/help/Set-AzExpressRouteCircuitConnectionConfig .md
Outdated
Show resolved
Hide resolved
src/Network/Network/help/Set-AzExpressRouteCircuitConnectionConfig .md
Outdated
Show resolved
Hide resolved
Contributor
Author
|
The branch had merge conflicts. I have created another review #10990, with a different branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are in the process of adding support for IPv6 in ExpressRouteCircuitConnectionConfig.
In the process, we have updated the existing PowerShell cmdlet
Add-AzExpressRouteCircuitConnectionConfig to accept another optional parameter AddressPrefixType (that optionally specifies the address family type for the address prefix).
In addition, we also introduced another cmdlet to modify the existing ExpressRouteCircuitConnectionConfig to add a new block IPv6CircuitConnectionConfig as well.
This would be used to update any existing GlobalReach configuration (ExpressRouteCircuitConnection) configurations.
Below is the design PR
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/451#event-2913187208
This pull request brings in the changes in the powershell sdk.
The relevant swagger changes are to be merged in network-december-release.
Azure/azure-rest-api-specs#8145
NRP changes are already merged.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added