Skip to content

Conversation

@amwate
Copy link
Contributor

@amwate amwate commented Jan 29, 2020

Description

We are in the process of adding support for IPv6 in ExpressRouteCircuitConnectionConfig.

In the process, we have updated the existing PowerShell cmdlet
Add-AzExpressRouteCircuitConnectionConfig to accept another optional parameter AddressPrefixType (that optionally specifies the address family type for the address prefix).

In addition, we also introduced another cmdlet to modify the existing ExpressRouteCircuitConnectionConfig to add a new block IPv6CircuitConnectionConfig as well.
This would be used to update any existing GlobalReach configuration (ExpressRouteCircuitConnection) configurations.

Below is the design PR
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/451#event-2913187208

This pull request brings in the changes in the powershell sdk.
The relevant swagger changes are to be merged in network-december-release.
Azure/azure-rest-api-specs#8145

NRP changes are already merged.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

deveshguha and others added 30 commits January 8, 2020 10:29
If using RehydratePriority, then the source blob is already in archive. Destination blob cannot also be in archive with copyblob
[Storage] Show RequestId when StorageException don't have ExtendedErrorInformation, and fix a help example
[Compute] ColocationStatus for PPG.
DeploymentManager module update for new API version
…yptionSetId parameter to New-AzDiskUpdateConfig and New-AzSnapshotUpdateConfig
Update Set-AzNetworkWatcherConfigFlowLog.md
Make -Scope optional in *-AzPolicyAssignment cmdlets
[Compute] Disk encryption update
@amwate amwate changed the title Eri pv6 gr add set cmdlet v1 [Express Route] IPv6 Global Reach Add/Set-AzExpressRouteCircuitConnection cmdlet changes. Jan 30, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amwate , please

  • write tests for the new cmdlet
  • fix CI failures
  • and see my inline comments
    Thanks


if (null == circuitconnection)
{
throw new ArgumentException(string.Format("Circuit Connection with Name {0} was not added to the private peering", Name));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use resource string.

using System.Management.Automation;

namespace Microsoft.Azure.Commands.Network {
[CmdletOutputBreakingChange(typeof(PSExpressRouteCircuit), DeprecatedOutputProperties = new[] { "AllowGlobalReach" })]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why will there be a breaking change?

@amwate
Copy link
Contributor Author

amwate commented Apr 6, 2020

Creating a new pull request #11501.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.