-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Express Route] IPv6 Global Reach Add/Set-AzExpressRouteCircuitConnection cmdlet changes. #10990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If using RehydratePriority, then the source blob is already in archive. Destination blob cannot also be in archive with copyblob
[Storage] Show RequestId when StorageException don't have ExtendedErrorInformation, and fix a help example
[Compute] ColocationStatus for PPG.
DeploymentManager module update for new API version
…yptionSetId parameter to New-AzDiskUpdateConfig and New-AzSnapshotUpdateConfig
Update Set-AzNetworkWatcherConfigFlowLog.md
Make -Scope optional in *-AzPolicyAssignment cmdlets
[Compute] Disk encryption update
Retargeting master pull request to release branch
powershell cmdlets for connection monitor V2
S164 Updating versions for Network and SQL Changes
Merge release branch -> master for 3.4.0
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amwate , please
- write tests for the new cmdlet
- fix CI failures
- and see my inline comments
Thanks
...ExpressRouteCircuit/Peering/Connection/SetAzureExpressRouteCircuitConnectionConfigCommand.cs
Show resolved
Hide resolved
|
|
||
| if (null == circuitconnection) | ||
| { | ||
| throw new ArgumentException(string.Format("Circuit Connection with Name {0} was not added to the private peering", Name)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use resource string.
| using System.Management.Automation; | ||
|
|
||
| namespace Microsoft.Azure.Commands.Network { | ||
| [CmdletOutputBreakingChange(typeof(PSExpressRouteCircuit), DeprecatedOutputProperties = new[] { "AllowGlobalReach" })] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why will there be a breaking change?
|
Creating a new pull request #11501. |
Description
We are in the process of adding support for IPv6 in ExpressRouteCircuitConnectionConfig.
In the process, we have updated the existing PowerShell cmdlet
Add-AzExpressRouteCircuitConnectionConfig to accept another optional parameter AddressPrefixType (that optionally specifies the address family type for the address prefix).
In addition, we also introduced another cmdlet to modify the existing ExpressRouteCircuitConnectionConfig to add a new block IPv6CircuitConnectionConfig as well.
This would be used to update any existing GlobalReach configuration (ExpressRouteCircuitConnection) configurations.
Below is the design PR
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/451#event-2913187208
This pull request brings in the changes in the powershell sdk.
The relevant swagger changes are to be merged in network-december-release.
Azure/azure-rest-api-specs#8145
NRP changes are already merged.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added