Skip to content

Conversation

@gkostal
Copy link
Member

@gkostal gkostal commented Mar 4, 2020

Description

The PSD1 file for the AzAttestation cmdlets is missing three required assemblies:

  • Microsoft.IdentityModel.JsonWebTokens
  • Microsoft.IdentityModel.Tokens
  • Microsoft.IdentityModel.Logging

This PR adds the missing assemblies. It also updates the Attestation.Test project to handle the conflict for the desired version number for the Microsoft.IdentityModel.Tokens assembly by the references from Microsoft.Rest.ClientRuntime.Azure.Authentication.dll and Microsoft.IdentityModel.JsonWebTokens.dll.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Mar 4, 2020

Can one of the admins verify this patch?

@VeryEarly VeryEarly merged commit f247883 into Azure:master Mar 5, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
…y-bug-pr

AzAttestation Bug Fix: Add three missing required assemblies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants