Skip to content

Conversation

@dingmeng-xue
Copy link
Member

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@dingmeng-xue dingmeng-xue added this to the S166 (2020-03-10) milestone Mar 6, 2020
@adxsdkps
Copy link
Collaborator

adxsdkps commented Mar 6, 2020

Can one of the admins verify this patch?

@dingmeng-xue dingmeng-xue requested a review from isra-fel March 6, 2020 06:26
ChangeLog.md Outdated

#### Az.Websites
* Added Tag parameter for 'New-AzAppServicePlan' and 'Set-AzAppServicePlan'
* Stop cmdlt execution if an exception is thrown when adding a custom domain to a website
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor typo

Suggested change
* Stop cmdlt execution if an exception is thrown when adding a custom domain to a website
* Stop cmdlet execution if an exception is thrown when adding a custom domain to a website

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix when it will be merged into master. No time to resolve it.

tools/Az/Az.psd1 Outdated
Description = 'Microsoft Azure PowerShell - Cmdlets to manage resources in Azure. This module is compatible with WindowsPowerShell and PowerShell Core.
For more information about the Az module, please visit the following: https://docs.microsoft.com/en-us/powershell/azure/'
For more information about the Az module, please visit the following: https://docs.microsoft.com/en-us/powershell/azure/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

tools/Az/Az.psd1 Outdated

# ReleaseNotes of this module
ReleaseNotes = '3.5.0 - February 2020
ReleaseNotes = '3.7.0 - March 2020
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ReleaseNotes = '3.7.0 - March 2020
ReleaseNotes = '3.6.0 - March 2020

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel assigned isra-fel and dingmeng-xue and unassigned isra-fel Mar 6, 2020
@dingmeng-xue dingmeng-xue merged commit 134f938 into Azure:release-2020-03-10 Mar 6, 2020
@dingmeng-xue dingmeng-xue deleted the release-2020-03-10 branch March 24, 2020 13:00
dingmeng-xue added a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants