Skip to content

Save sensitivity rank when classifying columns #11364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 20, 2020
Merged

Save sensitivity rank when classifying columns #11364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2dd8ffd
Merge pull request #1 from Azure/master
bashahee Mar 5, 2020
b2604f9
Adding SensitivityRank parameter to DataClassification Set Cmdlets
baselmicrosoft Mar 6, 2020
e22f6e7
Update syntax in help files.
baselmicrosoft Mar 13, 2020
71ee729
Consume modified SDK clients.
baselmicrosoft Mar 16, 2020
4afc433
Remove unnecessary changes.
baselmicrosoft Mar 16, 2020
81f36dd
Update tests, tests records and help files.
baselmicrosoft Mar 17, 2020
d81dad5
Update tests file.
baselmicrosoft Mar 18, 2020
b3d0ae4
Adding SensitivityRank parameter to DataClassification Set Cmdlets
baselmicrosoft Mar 6, 2020
0630670
Update syntax in help files.
baselmicrosoft Mar 13, 2020
aa70b04
Consume modified SDK clients.
baselmicrosoft Mar 16, 2020
071a170
Remove unnecessary changes.
baselmicrosoft Mar 16, 2020
db55db6
Update tests, tests records and help files.
baselmicrosoft Mar 17, 2020
fbad5a1
Update tests file.
baselmicrosoft Mar 18, 2020
4ce5bbe
Merge branch 'Azure-master'
baselmicrosoft Mar 18, 2020
357970f
Update ChangeLog.md
baselmicrosoft Mar 18, 2020
6f09f8e
Update Management.Sql package version
bashahee Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Network/Network/Network.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<ItemGroup>
<PackageReference Include="AutoMapper" Version="6.2.2" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.18.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Sql" Version="1.40.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Sql" Version="1.41.0-preview" />
</ItemGroup>

<ItemGroup>
Expand Down
10 changes: 9 additions & 1 deletion src/Sql/Sql.Test/ScenarioTests/DataClassificationTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,25 +238,29 @@ function Test-DataClassificationOnSqlDatabase
$firstColumnName = $firstRecommendation.ColumnName
$firstInformationType = $firstRecommendation.InformationType
$firstSensitivityLabel = $firstRecommendation.SensitivityLabel
$firstRank = $firstRecommendation.Rank

Assert-AreEqual "dbo" $firstSchemaName
Assert-AreEqual "Persons" $firstTableName
Assert-NotNullOrEmpty $firstColumnName
Assert-NotNullOrEmpty $firstInformationType
Assert-NotNullOrEmpty $firstSensitivityLabel
Assert-NotNullOrEmpty $firstRank

$secondRecommendation = ($recommendations.SensitivityLabels)[1]
$secondSchemaName = $secondRecommendation.SchemaName
$secondTableName = $secondRecommendation.TableName
$secondColumnName = $secondRecommendation.ColumnName
$secondInformationType = $secondRecommendation.InformationType
$secondSensitivityLabel = $secondRecommendation.SensitivityLabel
$secondRank = $secondRecommendation.Rank

Assert-AreEqual "dbo" $secondSchemaName
Assert-AreEqual "Persons" $secondTableName
Assert-NotNullOrEmpty $secondColumnName
Assert-NotNullOrEmpty $secondInformationType
Assert-NotNullOrEmpty $secondSensitivityLabel
Assert-NotNullOrEmpty $secondRank

# Set first two sensitivity labels as recommended and verify.
# Second label is set using pipeline.
Expand All @@ -278,6 +282,7 @@ function Test-DataClassificationOnSqlDatabase
Assert-AreEqual $firstColumnName $classification.ColumnName
Assert-AreEqual $firstInformationType $classification.InformationType
Assert-AreEqual $firstSensitivityLabel $classification.SensitivityLabel
Assert-AreEqual $firstRank $classification.Rank

$secondClassification = Get-AzSqlDatabase -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName | Get-AzSqlDatabaseSensitivityClassification -SchemaName $secondSchemaName -TableName $secondTableName -ColumnName $secondColumnName
Assert-AreEqual 1 ($secondClassification.SensitivityLabels).count
Expand All @@ -287,6 +292,7 @@ function Test-DataClassificationOnSqlDatabase
Assert-AreEqual $secondColumnName $classification.ColumnName
Assert-AreEqual $secondInformationType $classification.InformationType
Assert-AreEqual $secondSensitivityLabel $classification.SensitivityLabel
Assert-AreEqual $secondRank $classification.Rank

# Get, using pipeline, recommended sensitivity labels, and verify.
$recommendations = Get-AzSqlDatabase -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName | Get-AzSqlDatabaseSensitivityRecommendation
Expand Down Expand Up @@ -503,6 +509,8 @@ function Create-SqlDataClassificationTestEnvironment ($testSuffix, $location = "
New-AzSqlServer -ResourceGroupName $params.rgname -ServerName $params.serverName -ServerVersion $serverVersion -Location $location -SqlAdministratorCredentials $credentials
New-AzSqlServerFirewallRule -ResourceGroupName $params.rgname -ServerName $params.serverName -StartIpAddress 0.0.0.0 -EndIpAddress 255.255.255.255 -FirewallRuleName "dcRule"

# Enable Advanced Data Security
Enable-AzSqlServerAdvancedDataSecurity -ResourceGroupName $params.rgname -ServerName $params.serverName -DoNotConfigureVulnerabilityAssessment

New-AzSqlDatabase -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName

Expand Down Expand Up @@ -577,7 +585,7 @@ function Test-EnableDisableRecommendationsOnSqlDatabase
Assert-NotNullOrEmpty $secondInformationType
Assert-NotNullOrEmpty $secondSensitivityLabel

# Disable first two recommdationsd, second recommdation is disabled using pipeline.
# Disable first two recommdations, second recommdation is disabled using pipeline.
Disable-AzSqlDatabaseSensitivityRecommendation -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -SchemaName $firstSchemaName -TableName $firstTableName -ColumnName $firstColumnName
Get-AzSqlDatabase -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName | Disable-AzSqlDatabaseSensitivityRecommendation -SchemaName $secondSchemaName -TableName $secondTableName -ColumnName $secondColumnName

Expand Down
2,198 changes: 1,321 additions & 877 deletions ...s.Sql.Test.ScenarioTests.DataClassificationTests/TestDataClassificationOnSqlDatabase.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading