Skip to content

Add one smoke test for set a resource tag case #11385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10,000 commits into from
Closed

Add one smoke test for set a resource tag case #11385

wants to merge 10,000 commits into from

Conversation

@Grayer123
Copy link
Contributor

@Grayer123 Grayer123 commented Mar 20, 2020 •
edited
Loading

Description

Add one smoke test for set a resource tag case
Address issue: Add end-to-end test automation verifying case preservation in Tag keys and Values

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

VeryEarly and others added 30 commits March 3, 2020 15:52
@VeryEarly
Update ChangeLog.md
898ec97
@VeryEarly
Merge branch 'master' into patch-9
3a41a1b
@wyunchi-ms
Merge pull request Azure#11231 from dingmeng-xue/release-2020-03-10
9813b78 
Polish changelog.md
@dingmeng-xue
3.6.0 RC1
bca9bb6
@aygoya
new severity - highest critical impact.
b4232a8
@aygoya
Resource type
9924d86
@xaliciayang
updated tests; renamed parameters for consistency; adjusted backups A…
7838b87 
…PI to be more user-friendly; added session recording for LTR MI Policy
@cicovica
Update MI and SQL DB Server CRUD tests
886eefd
@wyunchi1990
update changelog for Az.Network
870cd91
@amolagar5
regenerate the help file.
d8d9372
@nagula-ritvika
pass custom headers for cross tenant hubvnet conn
075cb51
@nagula-ritvika
remove extra line
4783191
@amolagar5
regenerate blank file and see if that works.
d27f305
@amolagar5
add online version to help file. Looks like that has become compulsor…
cc9c7a3 
…y now.
@anusapan
merged from master
46522da
@amolagar5
update ChangeLog.md
e4951e1
@ziwa-msft
Added test recordings for Sql DB and bumped version for management.sql
2a676c5
@nagula-ritvika
pass auth headers from both cmdlets
ca867e1
@ziwa-msft
add mi test
440f3b7
@ziwa-msft
test udpate
f079997
@ziwa-msft
test fix
c72198f
@xaliciayang
fixed some tests; including all session tests (with mock resources)
1be0731
@ziwa-msft
Added test recording
19b7a14
@ziwa-msft
Update changelog
65f674a
@ziwa-msft
trivial fix
c6301f6
@ziwa-msft
fix helpn files
c705760
@ziwa-msft
fixing test failuires
dcd7a5d
@xaliciayang
some fixes in remove backup; redid session records, minor fixes throu…
52ce17a 
…ghout
@ziwa-msft
moving seesion record to the right folder
2f4d9af
@ziwa-msft
added az.network to changelog
fe417a1
Zhenyu Zhou and others added 12 commits March 20, 2020 13:28
1.Support customers specify min TLS version when creating cluster
06f9731 
2. Update New-AzHDInsightConfig.md
@sambitratha
Added retrying policy update
6574265
@isra-fel
Merge pull request Azure#11350 from hyonholee/march
6d3ec97 
[Compute] Fix AutomaticRepairsPolicy issue
@sambitratha
updated paramsets and added help file
477a972
@isra-fel
Merge pull request Azure#11364 from bashahee/master
55ed2d4 
Save sensitivity rank when classifying columns
@anton-evseev
Merge branch 'network-january' into merge-network-january
c9c481d 
# Conflicts:
#	src/CognitiveServices/CognitiveServices.Test/CognitiveServices.Test.csproj
#	src/Network/Network/Network.csproj
#	src/RecoveryServices/RecoveryServices.Backup.Test/RecoveryServices.Backup.Test.csproj
#	src/RecoveryServices/RecoveryServices.SiteRecovery.Test/RecoveryServices.SiteRecovery.Test.csproj
#	src/SqlVirtualMachine/SqlVirtualMachine.Test/SqlVirtualMachine.Test.csproj
@anton-evseev
Fix after merge
95c7f7e
@isra-fel
Merge pull request Azure#11366 from LijuanZ/lijzha/updateCreateRun
7699fdc 
DataFactory: Add optional parameters to Invoke-AzDataFactoryV2Pipeline to support rerun
@isra-fel
Merge pull request Azure#11359 from MabOneSdk/users/sarath/modify-policy
9fb02d3 
Added support for retry policy update for failed items
@isra-fel
Merge pull request Azure#11344 from aim-for-better/AddMinSupportedTls…
01aa111 
…Version

[HDInsight] Support customers specify min TLS version when creating cluster
@isra-fel
Merge pull request Azure#11379 from number213/merge-network-january
39f1727 
Network release
@Grayer123
Add one smoke test for set a resource tag case.
1212f3f
@Grayer123 Grayer123 requested a review from hamidtirmizi March 20, 2020 16:56
@adxsdkps
Copy link
Collaborator

adxsdkps commented Mar 20, 2020

Can one of the admins verify this patch?

hamidtirmizi
hamidtirmizi reviewed Mar 20, 2020
View reviewed changes
hamidtirmizi
hamidtirmizi reviewed Mar 20, 2020
View reviewed changes
hamidtirmizi
hamidtirmizi suggested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@hamidtirmizi hamidtirmizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to write parts of the test that are explained in the comments

@msJinLei
Copy link
Contributor

msJinLei commented Mar 26, 2020

@hamidtirmizi Could you take a look at the @Grayer123's change? Thanks

@msJinLei
Copy link
Contributor

msJinLei commented Apr 10, 2020

@Grayer123 Please resolve the conflict

@Grayer123 Grayer123 mentioned this pull request Apr 17, 2020
Merged
8 tasks
@Grayer123
Copy link
Contributor Author

Grayer123 commented Apr 20, 2020

Close this pr due to a force-pushed into master, as a new pr created.

@Grayer123 Grayer123 closed this Apr 20, 2020
@Grayer123 Grayer123 deleted the feature/testTag branch August 2, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hamidtirmizi hamidtirmizi hamidtirmizi requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hamidtirmizi hamidtirmizi

Labels

needs-revision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.