From 36b5d8b4f6b2e3ec4410c1a36a36a95d58582dfe Mon Sep 17 00:00:00 2001 From: Rahul Dutta Date: Mon, 23 Mar 2020 12:14:56 -0700 Subject: [PATCH 1/2] Add breaking change description for Export-AzDataLakeStoreItem and Import-AzDataLakeStoreItem --- src/DataLakeStore/DataLakeStore/ChangeLog.md | 3 ++- .../DataPlaneCommands/ExportAzureRmDataLakeStoreItem.cs | 5 +++-- .../DataPlaneCommands/ImportAzureRmDataLakeStoreItem.cs | 3 ++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/DataLakeStore/DataLakeStore/ChangeLog.md b/src/DataLakeStore/DataLakeStore/ChangeLog.md index cae8ce6f4346..1f23610a1a9c 100644 --- a/src/DataLakeStore/DataLakeStore/ChangeLog.md +++ b/src/DataLakeStore/DataLakeStore/ChangeLog.md @@ -18,7 +18,8 @@ - Additional information about change #1 --> ## Upcoming Release -Added option of Byte encoding for New-AzDataLakeStoreItem, Add-AzDAtaLakeStoreItemContent, Get-AzDAtaLakeStoreItemContent +* Added option of Byte encoding for New-AzDataLakeStoreItem, Add-AzDAtaLakeStoreItemContent, Get-AzDAtaLakeStoreItemContent +* Add breaking change description for Export-AzDataLakeStoreItem and Import-AzDataLakeStoreItem ## Version 1.2.7 * Added reference to System.Buffers explicitly in csproj and psd1. diff --git a/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ExportAzureRmDataLakeStoreItem.cs b/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ExportAzureRmDataLakeStoreItem.cs index 9059f090ce0e..b705e3770054 100644 --- a/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ExportAzureRmDataLakeStoreItem.cs +++ b/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ExportAzureRmDataLakeStoreItem.cs @@ -12,15 +12,16 @@ // limitations under the License. // ---------------------------------------------------------------------------------- -using System; -using Microsoft.Azure.Commands.DataLakeStore.Properties; + using Microsoft.Azure.Commands.DataLakeStore.Models; using Microsoft.Rest.Azure; using System.Management.Automation; using Microsoft.Azure.DataLake.Store; +using Microsoft.WindowsAzure.Commands.Common.CustomAttributes; namespace Microsoft.Azure.Commands.DataLakeStore { + [GenericBreakingChange("For store side export failures, Export-AzDataLakeStoreItem will throw exception instead of printing message on screen", "2.0.0")] [Cmdlet("Export", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "DataLakeStoreItem", SupportsShouldProcess = true, DefaultParameterSetName = BaseParameterSetName), OutputType(typeof(string))] [Alias("Export-AdlStoreItem")] public class ExportAzureDataLakeStoreItem : DataLakeStoreFileSystemCmdletBase diff --git a/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ImportAzureRmDataLakeStoreItem.cs b/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ImportAzureRmDataLakeStoreItem.cs index 44b2a1c3b186..d267f29d32d3 100644 --- a/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ImportAzureRmDataLakeStoreItem.cs +++ b/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ImportAzureRmDataLakeStoreItem.cs @@ -12,15 +12,16 @@ // limitations under the License. // ---------------------------------------------------------------------------------- -using System; using Microsoft.Azure.Commands.DataLakeStore.Models; using Microsoft.Azure.Commands.DataLakeStore.Properties; using System.Management.Automation; using Microsoft.Azure.DataLake.Store; using Microsoft.Rest.Azure; +using Microsoft.WindowsAzure.Commands.Common.CustomAttributes; namespace Microsoft.Azure.Commands.DataLakeStore { + [GenericBreakingChange("For store side import failures, Import-AzDataLakeStoreItem will throw exception instead of printing message on screen", "2.0.0")] [Cmdlet("Import", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "DataLakeStoreItem", SupportsShouldProcess = true, DefaultParameterSetName = BaseParameterSetName), OutputType(typeof(string))] [Alias("Import-AdlStoreItem")] public class ImportAzureDataLakeStoreItem : DataLakeStoreFileSystemCmdletBase From c779b912990e9f878046656dcd81a6152d743473 Mon Sep 17 00:00:00 2001 From: Rahul Dutta Date: Tue, 24 Mar 2020 13:15:20 -0700 Subject: [PATCH 2/2] add breaking change date --- .../DataPlaneCommands/ExportAzureRmDataLakeStoreItem.cs | 2 +- .../DataPlaneCommands/ImportAzureRmDataLakeStoreItem.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ExportAzureRmDataLakeStoreItem.cs b/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ExportAzureRmDataLakeStoreItem.cs index b705e3770054..d975d3fe2952 100644 --- a/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ExportAzureRmDataLakeStoreItem.cs +++ b/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ExportAzureRmDataLakeStoreItem.cs @@ -21,7 +21,7 @@ namespace Microsoft.Azure.Commands.DataLakeStore { - [GenericBreakingChange("For store side export failures, Export-AzDataLakeStoreItem will throw exception instead of printing message on screen", "2.0.0")] + [GenericBreakingChange("For store side export failures, Export-AzDataLakeStoreItem will throw exception instead of printing message on screen", "2.0.0", "05/18/2020")] [Cmdlet("Export", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "DataLakeStoreItem", SupportsShouldProcess = true, DefaultParameterSetName = BaseParameterSetName), OutputType(typeof(string))] [Alias("Export-AdlStoreItem")] public class ExportAzureDataLakeStoreItem : DataLakeStoreFileSystemCmdletBase diff --git a/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ImportAzureRmDataLakeStoreItem.cs b/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ImportAzureRmDataLakeStoreItem.cs index d267f29d32d3..3e7941e442ce 100644 --- a/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ImportAzureRmDataLakeStoreItem.cs +++ b/src/DataLakeStore/DataLakeStore/DataPlaneCommands/ImportAzureRmDataLakeStoreItem.cs @@ -21,7 +21,7 @@ namespace Microsoft.Azure.Commands.DataLakeStore { - [GenericBreakingChange("For store side import failures, Import-AzDataLakeStoreItem will throw exception instead of printing message on screen", "2.0.0")] + [GenericBreakingChange("For store side import failures, Import-AzDataLakeStoreItem will throw exception instead of printing message on screen", "2.0.0", "05/18/2020")] [Cmdlet("Import", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "DataLakeStoreItem", SupportsShouldProcess = true, DefaultParameterSetName = BaseParameterSetName), OutputType(typeof(string))] [Alias("Import-AdlStoreItem")] public class ImportAzureDataLakeStoreItem : DataLakeStoreFileSystemCmdletBase