Skip to content

[KeyVault] add breaking change attributes #11408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2020
Merged

[KeyVault] add breaking change attributes #11408

merged 3 commits into from
Mar 25, 2020

Conversation

@isra-fel
Copy link
Member

@isra-fel isra-fel commented Mar 24, 2020 •
edited
Loading

Description

This PR adds breaking change attributes to New-AzKeyVault. The actual breaking change is planned to be checked in in //build release.

Warning example:

image

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Mar 24, 2020

Can one of the admins verify this patch?

@isra-fel
Copy link
Member Author

isra-fel commented Mar 24, 2020

Hi Jin Lei, when you merge this PR please use squash thanks.

@isra-fel
Copy link
Member Author

isra-fel commented Mar 24, 2020

@isra-fel isra-fel assigned isra-fel and unassigned msJinLei Mar 25, 2020
@isra-fel
Copy link
Member Author

isra-fel commented Mar 25, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Mar 25, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel force-pushed the yeming/keyvault-breaking-note branch from cae4e9f to 981c543 Compare March 25, 2020 05:49
isra-fel
isra-fel commented Mar 25, 2020
View reviewed changes
src/Compute/Compute.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "KeyVault", "..\KeyVault\KeyVault\KeyVault.csproj", "{9FFC40CC-A341-4D0C-A25D-DC6B78EF6C94}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ManagedServiceIdentity", "..\ManagedServiceIdentity\ManagedServiceIdentity.csproj", "{228EB071-FA04-43B3-95F9-7D76DBF0B850}"
Copy link
Member Author

@isra-fel isra-fel Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because compute is using cmdlets from Az.ManagedServiceIdentity in their tests.

@isra-fel isra-fel assigned dingmeng-xue and unassigned isra-fel Mar 25, 2020
@isra-fel
Copy link
Member Author

isra-fel commented Mar 25, 2020

Hi @dingmeng-xue the last sprint candidate is ready for review. Thanks

@dingmeng-xue dingmeng-xue merged commit 19b19ea into Azure:release-2020-03-31 Mar 25, 2020
@isra-fel isra-fel deleted the yeming/keyvault-breaking-note branch March 26, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dingmeng-xue dingmeng-xue dingmeng-xue approved these changes

Assignees

@dingmeng-xue dingmeng-xue

Labels

needs-review Sprint Candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isra-fel @adxsdkps @dingmeng-xue @msJinLei