Virtual Network Gateway Commandlets Update for BgpSettings #11424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ps metric definition
Add Minimal Tls Version Optional Parameter for SQLDB/MI
…ets. (Microsoft.IdentityModel.*)
LTR MI cmdlets and tests
AzAttestation Bug Fix: Add three missing required assemblies
Update samples to use proper argument -GalleryImageDefinitionName not -ImageDefinitionName
…gelog Update changelog for Az.Network
anton-evseev
previously approved these changes
Mar 27, 2020
Contributor
anton-evseev
left a comment
anton-evseev
left a comment
There was a problem hiding this comment.
LGTM but please also generate help file for new cmdlet
Member
Author
Added help file. Thanks |
added 2 commits
March 31, 2020 18:47
isra-fel
added
Cmdlet Review Complete
needs-review
and removed
Cmdlet Review Required ⚠️
labels
New vngbg pchanges
msJinLei
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
37 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are introducing a new PSIpConfigurationBgpPeeringAddress object which will be used in PSBgpSettings. Customer can provide bgpPeering addresses for the gateway using this property.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/Network/Network/ChangeLog.md## Upcoming Releaseheader -- no new version header should be addedhttps://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/514 (Microsoft internal only)