Skip to content

Removed default population of access policies #11570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Removed default population of access policies #11570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/HealthcareApis/HealthcareApis/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Access policies are no longer defaulted to the current principal

## Version 1.0.1
* Update references in .psd1 to use relative path
Expand Down
16 changes: 6 additions & 10 deletions src/HealthcareApis/HealthcareApis/HealthcareApis/NewAzureRmHealthcareApisService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,17 +208,13 @@ private List<ServiceAccessPolicyEntry> GetAccessPolicies()
{
List<ServiceAccessPolicyEntry> accessPolicies = new List<ServiceAccessPolicyEntry>();

if (AccessPolicyObjectId == null || AccessPolicyObjectId.Length == 0)
if (AccessPolicyObjectId != null && AccessPolicyObjectId.Length > 0)
{
string objectID = base.AccessPolicyID;
accessPolicies.Add(new ServiceAccessPolicyEntry(objectID));
return accessPolicies;
}

foreach (var objectID in AccessPolicyObjectId)
{
HealthcareApisArgumentValidator.ValidateObjectId(objectID);
accessPolicies.Add(new ServiceAccessPolicyEntry(objectID));
foreach (var objectID in AccessPolicyObjectId)
{
HealthcareApisArgumentValidator.ValidateObjectId(objectID);
accessPolicies.Add(new ServiceAccessPolicyEntry(objectID));
}
}

return accessPolicies;
Expand Down