From 6f9b97b3919eeeefd1b079618bff57d0681009e6 Mon Sep 17 00:00:00 2001 From: Wei Wei Date: Mon, 21 Oct 2019 10:16:33 +0800 Subject: [PATCH] [Storage] change default action to make it align with swagger --- src/Storage/Storage.Management/ChangeLog.md | 3 +++ src/Storage/Storage.Management/Models/PSNetworkRule.cs | 4 ++-- .../StorageAccount/UpdateAzureStorageAccountNetworkRuleSet.cs | 2 -- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Storage/Storage.Management/ChangeLog.md b/src/Storage/Storage.Management/ChangeLog.md index e81da8d1e2f6..8f7483174cb1 100644 --- a/src/Storage/Storage.Management/ChangeLog.md +++ b/src/Storage/Storage.Management/ChangeLog.md @@ -18,6 +18,9 @@ - Additional information about change #1 --> ## Upcoming Release +* Change NetWorkRule DefaultAction value defination to align with swagger. + - Update-AzStorageAccountNetworkRuleSet + - Get-AzStorageAccountNetworkRuleSet ## Version 1.14.0 * Added breaking change notice for Azure File cmdlets output change in a future release diff --git a/src/Storage/Storage.Management/Models/PSNetworkRule.cs b/src/Storage/Storage.Management/Models/PSNetworkRule.cs index 9acce16af070..d02d94bd4b1e 100644 --- a/src/Storage/Storage.Management/Models/PSNetworkRule.cs +++ b/src/Storage/Storage.Management/Models/PSNetworkRule.cs @@ -32,8 +32,8 @@ public enum PSNetWorkRuleBypassEnum //Wrapper of NetworkRuleSet property DefaultAction public enum PSNetWorkRuleDefaultActionEnum { - Deny = 0, - Allow = 1 + Allow = 0, + Deny = 1 } //Wrapper of NetworkRule property Action diff --git a/src/Storage/Storage.Management/StorageAccount/UpdateAzureStorageAccountNetworkRuleSet.cs b/src/Storage/Storage.Management/StorageAccount/UpdateAzureStorageAccountNetworkRuleSet.cs index 46faee3c502f..24c4801b06ea 100644 --- a/src/Storage/Storage.Management/StorageAccount/UpdateAzureStorageAccountNetworkRuleSet.cs +++ b/src/Storage/Storage.Management/StorageAccount/UpdateAzureStorageAccountNetworkRuleSet.cs @@ -62,8 +62,6 @@ public PSNetWorkRuleBypassEnum Bypass } } - public const string ChangeDesc = "The DefaultAction value will change in a future release from: Allow = 1, Deny = 0, to: Allow = 0, Deny = 1."; - [CmdletParameterBreakingChange("DefaultAction", ChangeDescription = ChangeDesc)] [Parameter( Mandatory = false, HelpMessage = "Storage Account NetworkRule DefaultAction.")]