Skip to content

Conversation

@sivanguetta
Copy link
Contributor

Description

Support WebTest availability criteria for metric alert V2

  • New-AzMetricAlertRuleV2Criteria: an option to create webtest availability criteria was added
  • Add-AzMetricAlertRuleV2: supports the new webtest availability criteria

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented May 4, 2020

Can one of the admins verify this patch?

@isra-fel isra-fel self-assigned this May 6, 2020
/// Gets or sets the rule AvailabilityCriteria
/// </summary>
[Parameter(ParameterSetName = AvailabilityParameterSet, Mandatory = true, HelpMessage = "Switch parameter for using availability criteria Type")]
public SwitchParameter WebTest { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think -WebTestId can already differentiate the parameter set, so -WebTest can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think -WebTestId can already differentiate the parameter set, so -WebTest can be removed.

@isra-fel Thank you for the review,
I consulted about it with our PM @harelbr and he asked to keep this parameter and make it optional.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit cb5773f into Azure:master May 7, 2020
VeryEarly pushed a commit to VeryEarly/azure-powershell that referenced this pull request May 7, 2020
…re#11787)

* Support Application Insights web test alert rules via PowerShell

* Upgrade Microsoft.Azure.Management.Monitor nuget for Sql.Test

* Make WebTest switch parameter optional
VeryEarly added a commit that referenced this pull request May 8, 2020
* apply SDK back

* apply SDK back

* update parameter for new-azapplicationinsights and create cmdlet update-azapplicationsights

* create cmdlets for ApplicationInsightsLinkedStorageComponent

* typo fix

* export linkedStorageAccount cmdlets

* use RestException to catch 'NotFound' without response body

* add test case for ApplicationInsights CRUD

* add test cases for linked storage account

* generate help for new cmdlets

* update test cases

* update test cases and add record json

* update test cases and add record json

* upgrade applicationinsights SDK

* update test cases

* update help

* fix help

* add default parameter set for linked storage account related cmdlets

* update applicationinsight sdk reference in monitor

* re-record test cases

* update test cases

* update test case and record json

* update record json

* update help markdown

* Update Update-AzApplicationInsights.md

* Support Application Insights web test alert rules via PowerShell (#11787)

* Support Application Insights web test alert rules via PowerShell

* Upgrade Microsoft.Azure.Management.Monitor nuget for Sql.Test

* Make WebTest switch parameter optional

* update record json

Co-authored-by: sivanguetta <46525261+sivanguetta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants