-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Support Application Insights web test alert rules via PowerShell #11787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
| /// Gets or sets the rule AvailabilityCriteria | ||
| /// </summary> | ||
| [Parameter(ParameterSetName = AvailabilityParameterSet, Mandatory = true, HelpMessage = "Switch parameter for using availability criteria Type")] | ||
| public SwitchParameter WebTest { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think -WebTestId can already differentiate the parameter set, so -WebTest can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…re#11787) * Support Application Insights web test alert rules via PowerShell * Upgrade Microsoft.Azure.Management.Monitor nuget for Sql.Test * Make WebTest switch parameter optional
* apply SDK back * apply SDK back * update parameter for new-azapplicationinsights and create cmdlet update-azapplicationsights * create cmdlets for ApplicationInsightsLinkedStorageComponent * typo fix * export linkedStorageAccount cmdlets * use RestException to catch 'NotFound' without response body * add test case for ApplicationInsights CRUD * add test cases for linked storage account * generate help for new cmdlets * update test cases * update test cases and add record json * update test cases and add record json * upgrade applicationinsights SDK * update test cases * update help * fix help * add default parameter set for linked storage account related cmdlets * update applicationinsight sdk reference in monitor * re-record test cases * update test cases * update test case and record json * update record json * update help markdown * Update Update-AzApplicationInsights.md * Support Application Insights web test alert rules via PowerShell (#11787) * Support Application Insights web test alert rules via PowerShell * Upgrade Microsoft.Azure.Management.Monitor nuget for Sql.Test * Make WebTest switch parameter optional * update record json Co-authored-by: sivanguetta <46525261+sivanguetta@users.noreply.github.com>
Description
Support WebTest availability criteria for metric alert V2
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added