Skip to content

Show deployment script error in output; refactor deployments error msg improvements #11791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyunchi-ms merged 12 commits into from
May 7, 2020
Merged

Show deployment script error in output; refactor deployments error msg improvements #11791

wyunchi-ms merged 12 commits into from
May 7, 2020

Conversation

@filizt
Copy link
Contributor

@filizt filizt commented May 4, 2020 •
edited
Loading

Description

This Pr contains the changes to add ability to show error outputs for Deployment Scripts and refactoring of deployments error msg improvments.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@filizt filizt changed the title Add ability to show deployment script error as output; refactor deployments error msg improvements Show deployment script error in output; refactor deployments error msg improvements May 4, 2020
@filizt filizt requested a review from wyunchi-ms May 5, 2020 20:39
@isra-fel isra-fel self-assigned this May 6, 2020
isra-fel
isra-fel reviewed May 6, 2020
View reviewed changes
src/Resources/ResourceManager/SdkClient/ResourceManagerSdkClient.cs Outdated
using Microsoft.WindowsAzure.Commands.Utilities.Common;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using System;
Copy link
Member

@isra-fel isra-fel May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a bad merging

@isra-fel
Copy link
Member

isra-fel commented May 6, 2020

please update changelog.md too

wyunchi-ms
wyunchi-ms reviewed May 7, 2020
View reviewed changes
@wyunchi-ms wyunchi-ms merged commit 88ffc06 into Azure:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel left review comments

@wyunchi-ms wyunchi-ms wyunchi-ms approved these changes

Assignees

@isra-fel isra-fel

@filizt filizt

Labels

needs-revision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filizt @isra-fel @wyunchi-ms