-
Notifications
You must be signed in to change notification settings - Fork 4.1k
DNS Proxy support for Azure Firewall #11808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
7f1b49a to
e675f94
Compare
|
Also please fix the test. |
|
Please use Network SDK version 19.21.0-preview (see #11814) |
e675f94 to
530a864
Compare
Changed as per recommendation |
Changed as per recommendation |
9f99f38 to
01998aa
Compare
|
The test recording is NOT updated because local build no longer works for network-april branch after the SDK update. So the test recording here needs to be updated. If the branch itself could be fixed, that would be great. I found a way to fix the build and test. I will upload the new test recording soon. Thx. @isra-fel updated test checked in. |
01998aa to
c1923de
Compare
|
@tejasshah7 there are still cases failing. |
ecde7fe to
6f53959
Compare
6f53959 to
536a63e
Compare
|
|
|
@tejasshah7 there are still issues with Firewall tests, could you please pull this rebased branch and resolve them? |
536a63e to
2ef6250
Compare
@number213 Rebased and fixed |
2ef6250 to
5d08af6
Compare
|
Looks good to me. @wyunchi-ms could you help merge it? Thanks |
Description
(Creating PR on behalf of @tejasshah7 as the original PR #11807 contains to many conflicts.)
These changes are to add support for DNS Proxy options to Azure Firewall command. 3 new parameters are added.
Allowed:
New-AzFirewall -Name "azFw" -ResourceGroupName $rgName -Location centralus -VirtualNetwork $vnet -PublicIpAddress $pip -DNSEnableProxy true -DNSServers @("10.10.10.1", "20.20.20.2")
Allowed only if no Network Rules have FQDNs:
New-AzFirewall -Name "azFw" -ResourceGroupName $rgName -Location centralus -VirtualNetwork $vnet -PublicIpAddress $pip -DNSRequireProxyForNetworkRules false
Only validation required is
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added