Skip to content

Conversation

@isra-fel
Copy link
Member

@isra-fel isra-fel commented May 11, 2020

Description

This test project is to test code in #11864
Need to add more test cases.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@isra-fel isra-fel marked this pull request as draft May 11, 2020 06:17
@isra-fel isra-fel changed the title Add test project from Tools.Common Add test project for Tools.Common May 11, 2020
@isra-fel isra-fel marked this pull request as ready for review May 11, 2020 07:24
@isra-fel
Copy link
Member Author

@dingmeng-xue I wrote a test project for Tools.Common and added a few test cases.
It is not run during CI, as other test projects in tools/, but you can run it in VS.
image

@dingmeng-xue dingmeng-xue self-requested a review May 11, 2020 08:25
@dingmeng-xue
Copy link
Member

I think locally run is good enough. We don't need to enable test per CI for the time being.

@dingmeng-xue dingmeng-xue merged commit 44d6cef into master May 12, 2020
@isra-fel isra-fel deleted the yeming/test-tools-common branch May 12, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants