[Peering] Add API version 2020-04-01 #11907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeryEarly
reviewed
May 15, 2020
| /// </summary> | ||
| [Cmdlet(VerbsCommon.Get, Constants.AzPeeringReceivedRoutes, | ||
| DefaultParameterSetName = Constants.ParameterSetNameByResourceAndName)] | ||
| [OutputType(typeof(List<PSPeeringReceivedRoute>))] |
Collaborator
There was a problem hiding this comment.
the return type should be "PSPeeringReceivedRoute" instead of "List"
Collaborator
There was a problem hiding this comment.
Can you fix this and regenerate help markdown for it?
VeryEarly
reviewed
May 15, 2020
VeryEarly
reviewed
May 15, 2020
Collaborator
|
Hi @rileymckenna , |
Collaborator
|
/azp run |
Contributor
|
Pull request contains merge conflicts. |
Contributor
Author
|
@VeryEarly Made the changes and fixed the failing tests |
VeryEarly
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add api version 2020-04-01 support
add cmdlet Get-AzPeeringReceivedRoute
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be addedhttps://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/592