add private link parameters to data sync cmdlets #11947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is tied to the SDK change at Azure/azure-sdk-for-net#12179, and the design review at https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/596. I am submitting this in parallel before the previous ones get approved as this is a simple/localized change and we cannot really afford to wait for the next milestone.
This change adds a boolean UsePrivateLinkConnection parameter to the create and update commands for both sync groups and sync members, that indicates if the user wants sync groups to use private link connections. For the sync member case there is an extra resource ID that must be supplied to create the private link connection. Not supplying any of the new parameters keeps previous behavior.
Testing for the new behavior was done manually, as it requires manual setup. The old behavior is covered by existing tests.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added