Skip to content

Conversation

@ferno-ms
Copy link
Contributor

@ferno-ms ferno-ms commented May 19, 2020

Description

This is tied to the SDK change at Azure/azure-sdk-for-net#12179, and the design review at https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/596. I am submitting this in parallel before the previous ones get approved as this is a simple/localized change and we cannot really afford to wait for the next milestone.

This change adds a boolean UsePrivateLinkConnection parameter to the create and update commands for both sync groups and sync members, that indicates if the user wants sync groups to use private link connections. For the sync member case there is an extra resource ID that must be supplied to create the private link connection. Not supplying any of the new parameters keeps previous behavior.

Testing for the new behavior was done manually, as it requires manual setup. The old behavior is covered by existing tests.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@ferno-ms ferno-ms added this to the S170 (2020-06-02) milestone May 19, 2020
jaredmoo
jaredmoo previously approved these changes May 19, 2020
@VeryEarly VeryEarly self-assigned this May 20, 2020
@VeryEarly VeryEarly requested a review from jaredmoo May 20, 2020 11:05
@VeryEarly VeryEarly merged commit 82c5515 into Azure:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants