Skip to content

Conversation

@Xynoclafe
Copy link
Contributor

@Xynoclafe Xynoclafe commented May 19, 2020

Description

  • Formatted output property and show it on the Az-GetDeploymentScript cmdlet output
  • Renamed -DeploymentScriptInputObject parameter name to -DeploymentScriptObject (DeploymentScriptInputObject remains as an alias)
  • Fixed missing target name in what if result - Performing the operation "Remove Deployment Script" on target "".
  • Fix missing file name in message: "A file with the name '' already exists in directory 'C:'. This operation will replace the existing file. Would you like to continue?"
  • Ensure correct line endings are used in Az-SaveDeploymentScriptLog

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@Xynoclafe Xynoclafe requested a review from filizt May 19, 2020 20:52
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@VeryEarly VeryEarly self-assigned this May 20, 2020
string rowFormat = "{0, -" + maxNameLength + "} {1, -" + maxTypeLength + "}\r\n";
output.AppendLine();
output.AppendFormat(rowFormat, "Key", "Value");
output.AppendFormat(rowFormat, GeneralUtilities.GenerateSeparator(maxNameLength, "="), GeneralUtilities.GenerateSeparator(maxNameLength, "="));
Copy link
Contributor

@filizt filizt May 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GeneralUtilities.GenerateSeparator(maxNameLength, "=") [](start = 106, length = 55)

A bit confused with the use of maxTypeLength. You don't seem to use it in the AppendFormat, do we need it then? #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I think I can get rid of that variable. I was using it earlier to determine the length of the separating line at the top. It's redundant now.

@Xynoclafe Xynoclafe self-assigned this May 20, 2020
Copy link
Contributor

@filizt filizt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

filizt
filizt previously approved these changes May 22, 2020
@VeryEarly VeryEarly merged commit 77962a7 into Azure:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants