-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Changes to PS Deployment Script cmdlets #11951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to PS Deployment Script cmdlets #11951
Conversation
…to xynoclafe/PSDeploymentScript
…to xynoclafe/PSDeploymentScript
…to xynoclafe/PSDeploymentScript
… Save-AzDeploymentScriptLog cmdlet
…criptObject; Show Output property in cmdlet output
…Remove Deployment Script on target
…to xynoclafe/PSDeploymentScriptMisc
…to xynoclafe/PSDeploymentScriptMisc
|
Can one of the admins verify this patch? |
src/Resources/ResourceManager/Implementation/DeploymentScripts/SaveAzDeploymentScriptLog.cs
Outdated
Show resolved
Hide resolved
| string rowFormat = "{0, -" + maxNameLength + "} {1, -" + maxTypeLength + "}\r\n"; | ||
| output.AppendLine(); | ||
| output.AppendFormat(rowFormat, "Key", "Value"); | ||
| output.AppendFormat(rowFormat, GeneralUtilities.GenerateSeparator(maxNameLength, "="), GeneralUtilities.GenerateSeparator(maxNameLength, "=")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GeneralUtilities.GenerateSeparator(maxNameLength, "=") [](start = 106, length = 55)
A bit confused with the use of maxTypeLength. You don't seem to use it in the AppendFormat, do we need it then? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I think I can get rid of that variable. I was using it earlier to determine the length of the separating line at the top. It's redundant now.
filizt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added