Skip to content

Conversation

@amolagar5
Copy link
Contributor

@amolagar5 amolagar5 commented May 21, 2020

[SQL] Remove IsAzureADOnlyAuthentication from Set-AzSqlServerActiveDirectoryAdministrator

This is bein removed from the SQL in next iteration, so it will be useless to have in this cmdlet.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@VeryEarly VeryEarly self-assigned this May 21, 2020
@amolagar5
Copy link
Contributor Author

Looks like static analysis is failing as I am removing a parameter, This parameter is not used by customers as functionality was never publicly released. Design changed now, so a separate API is being added to release. How do I safely deprecate it.

@VeryEarly
Copy link
Collaborator

VeryEarly commented May 25, 2020

Looks like static analysis is failing as I am removing a parameter, This parameter is not used by customers as functionality was never publicly released. Design changed now, so a separate API is being added to release. How do I safely deprecate it.

Hi @amolagar ,

@amolagar5
Copy link
Contributor Author

Looks like static analysis is failing as I am removing a parameter, This parameter is not used by customers as functionality was never publicly released. Design changed now, so a separate API is being added to release. How do I safely deprecate it.

Hi @amolagar ,

Thanks @VeryEarly , I have added the suppress messages and resolved merged conflicts.

@VeryEarly VeryEarly merged commit 5800fdc into master May 27, 2020
@wyunchi-ms wyunchi-ms deleted the amagarwa/dev/ApplicationAsAADAdmin branch January 10, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants