Skip to content

Conversation

@VeryEarly
Copy link
Collaborator

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

erich-wang and others added 30 commits May 12, 2020 16:49
Example 2 for `Test-AzResourceGroupDeployment` was using the wrong command (`New-AzResourceGroupDeployment` instead of `Test-AzResourceGroupDeployment`)
* Add Az.Functions

* Update json recorded json files
* Update module list

* Add missed RPs
* zone to zone bug fixes

* updating the changeLog
* change dockerfile

* Fix pwsh cmd

* Fix dockerfile
* Migration Guide 4.0

Add script to generate Migration Guide Document

Add script to generate Migration Guide Document

* Update and rename Az.4.0.0-migration-guide.md to Az.4.1.0-migration-guide.md

* Update markdown and remove tools

* Update Az.4.1.0-migration-guide.md

* Update Az.4.1.0-migration-guide.md

* Update Az.4.1.0-migration-guide.md

Co-authored-by: wyunchi-ms <yunwang@microsoft.com>
Co-authored-by: Mike F. Robbins <mike.robbins@microsoft.com>
* update test

* update changelog

Co-authored-by: Daniel Orozco <Daniel.Orozco@microsoft.com>
…evice Provisioning Service. (Azure#11890)

* Manage device enrollments

* Record test session

* Fix online version in help file

* Add required assemblies
* zone to zone bug fixes

* updating the changeLog
* change dockerfile

* Fix pwsh cmd

* Fix dockerfile
* Migration Guide 4.0

Add script to generate Migration Guide Document

Add script to generate Migration Guide Document

* Update and rename Az.4.0.0-migration-guide.md to Az.4.1.0-migration-guide.md

* Update markdown and remove tools

* Update Az.4.1.0-migration-guide.md

* Update Az.4.1.0-migration-guide.md

* Update Az.4.1.0-migration-guide.md

Co-authored-by: wyunchi-ms <yunwang@microsoft.com>
Co-authored-by: Mike F. Robbins <mike.robbins@microsoft.com>
* update test

* update changelog

Co-authored-by: Daniel Orozco <Daniel.Orozco@microsoft.com>
…evice Provisioning Service. (Azure#11890)

* Manage device enrollments

* Record test session

* Fix online version in help file

* Add required assemblies
…re Active Directory admin. (Azure#11913)

Co-authored-by: Amol Agarwal <amagarwa@microsoft.com>
…ecordSet (Azure#11917)

* Correct verbose output string formatting for Remove Record Set from Private DNS Zone

* Update Change Log

Co-authored-by: Harmen Kahlon <hakahlon@microsoft.com>
…ntScriptLog cmdlets (Azure#11826)

* Add support for Tail and refactor code for new SDK version

* Added test cases

* Edited test cases

* Re-record test cases

* Modify help files

* Review fixes

* Fix CLI test case
… Hub Device Provisioning Service. (Azure#11926)

* Manage enrollment groups

* Add test session

* update help files
tony-xia and others added 7 commits May 20, 2020 18:42
* Fixed typos in comments

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* add private link parameters to data sync cmdlets

* update help files

* update changelog

* bump sql management nuget version

* use models from new sdk

* remove no longer needed .Properties on sync group model

* move operations to new sdk to fix build errors

* replace Hyak.Common with Microsoft.Rest.Azure
* z2z

* get output fix

* correcting get output

* fixing get output
@VeryEarly VeryEarly self-assigned this May 21, 2020
@VeryEarly VeryEarly changed the title Az.storage preview2 Az.storage preview May 21, 2020
@VeryEarly VeryEarly requested a review from blueww May 21, 2020 09:37
@VeryEarly VeryEarly changed the title Az.storage preview Az.storage preview (Do Not Squash) May 21, 2020
@blueww blueww added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label May 21, 2020
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 json file change should be removed from this PR:

  1. They will take difficulty when merge master to preview
  2. They are for breaking change tracking, not need add

@VeryEarly VeryEarly force-pushed the Az.Storage-Preview2 branch from d13ac63 to 2038833 Compare May 21, 2020 09:47
@VeryEarly VeryEarly force-pushed the Az.Storage-Preview2 branch from 2038833 to 992f77f Compare May 21, 2020 09:52
Copy link
Member

@blueww blueww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VeryEarly VeryEarly merged commit ca06a5f into Azure:Az.Storage-preview May 21, 2020
@VeryEarly VeryEarly deleted the Az.Storage-Preview2 branch June 3, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.