Skip to content

Conversation

@tejasshah7
Copy link
Contributor

Description

Add validation to the name field for ip groups

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@tejasshah7 tejasshah7 requested a review from anton-evseev as a code owner May 26, 2020 22:23
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

VeryEarly
VeryEarly previously approved these changes May 27, 2020
@VeryEarly VeryEarly self-assigned this May 27, 2020
@tejasshah7
Copy link
Contributor Author

@VeryEarly who is this pending on? I see you approved the changes but they are not merged. Thanks.

@VeryEarly VeryEarly merged commit 0d17313 into Azure:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants