Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Jun 30, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

chlahav and others added 30 commits June 2, 2020 19:45
Co-authored-by: Chen Lahav <chlahav@microsoft.com>
* Support capabilities.

* merge `Upcoming Release`
…#12041)

* fix thread error

* changelog

* chore: simplify code
* Send D2C message

* fixed static analysis issue

* Updated AssemblyVersionConflict

* Add SharedAssemblyConflict

* updated resource file

* fixed build issue
…ding change types (Azure#12039)

* Add ExcludeChangeTypes parameter to What-If cmdlets

* Add PSResourceManagerErrorFormatter

* Add license info

* Update help docs

* Updated ChangeLog.md

* Using singular parameter name

* Add scenario tests for ExcludeChangeType parameter

* Add unit tests for PSResourceManagerErrorFormatter

* Fix Linux and MacOS test errors
…ure#12045)

* Update Set-AzFirewall.md

Added an advanced example to update existing Azure Firewall rules using PowerShell based on customer feedback.

* Update ChangeLog.md

* Update ChangeLog.md

no need to update changelog for help changes

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
…#12054)

* initial commit

* Added MAB item models

* updated changelog

Co-authored-by: Sambit Rath <sarath@microsoft.com>
…ure#12060)

* Add SerializedJson for two released modules.

* Add some custom cmdlets

Co-authored-by: wyunchi-ms <yunwang@microsoft.com>
* Added Subscription Scope Type for Set-AzActionRule

* Updated ChangeLog.Md
Co-authored-by: wyunchi-ms <yunwang@microsoft.com>
* adding SourceWebApp.Location details

* Update ChangeLog.md

* Add Details in documentation

* Correcting powershell

* Remove app created to restore in case of Failure

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* Fix name of new VM Extension for SAP

* Update Changelog

* add secret suppress messages

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* Update DataClassificationEndpointsCommunicator.cs

* Update ChangeLog.md
…zure#12075)

* Add 'Delete' to the argument completer of EvictionPolicy parameter for New-AzVM and New-AzVMConfig cmdlets.

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
…ation (Azure#12083)

* updating the disk type

* updated help file

* updated as per comments
* update assembly version of Azure.Core

* Update ChangeLog.md

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
…erviceBus (Azure#12064)

- Add new examples to the following modules:
		ApiManagement
		DevTestLabs
		EventHub
		LogicApp
		ServiceBus

Co-authored-by: Maoliang Huang <mahuang@microsoft.com>
* support ARC senario

* support ARC senario -- add changelog

* upgrade guestconfiguration SDK version

* re-record tests

Co-authored-by: ge huang <gehuan@microsoft.com>
* add alias for functionparameter

* update changelog.md

* apply patch for saved searches operation when function parameter was not provided
…version (Azure#12084)

* Add a new function GetOldVersion and change the way of getting oldversion.

* Add return value to function GetOldVersion and change some logic to make it more readable.

* Merge the logic of judging preview version into GetOldVersion and return both version and ispreview.
* Bug fix for missing parameter is SetActionGroupCommand

* updated formatting

* Update ChangeLog.md

Co-authored-by: Ritwik Rajendra <rirajend@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
…cryption (Azure#12096)

* [Storage] Upgrade to SRP SDK 17.0.0

* [Storage] Support double Encryption
…Set-AzWebApp and Set-AzWebAppSlot (Azure#12107)

* Fixed bug that prevented changing Container settings in `Set-AzWebApp` and `Set-AzWebAppSlot`

* Adding tests and fixingTest-CreateNewWebAppHyperV false positive

Co-authored-by: Vini Soto <vsoto@microsoft.com>
* Command is not correct

We can use this command for secret not certificates because this command is not correct for certificates of KeyVault. When we use this command, the id will be below. I think this id is not correct for AppGW. 
https://xxxxx.vault.azure.net:443/certificates/xxxx/

The should be below. 

"KeyVaultSecretId": "https://xxxx.vault.azure.net:443/secrets/xxxx/"

When I used below command, I encountered error.

$secretId = $secret.Id.Replace($secret.Version, "")

"Set-AzApplicationGateway : SecretId 'https://xxxx.vault.azure.net:443/certificates/selftest/' specified in '/subscriptions/xxxxxxxxx/resourceGroups/apgw/p
roviders/Microsoft.Network/applicationGateways/AppGW/sslCertificates/SelfKeyCert' is invalid."

When I used below command, the operation was successful. So I think this document is not correct.

$secretId = $certificate.SecretId.Replace($certificate.Version, "")

* Command is not correct

This command is correct.

$secretId = $secret.SecretId.Replace($secret.Version, "")

* This command is correct.

I made a mistake. This is corrct.

Before
$secret.Id.Replace($secret.Version, "")

After
$secret.SecretId.Replace($secret.Version, "")

The Reason.

If we use below command, the URL will be "/certificates/" and it's invalid URL for AppGW.

 $secretId = $secret.Id.Replace($secret.Version, "")
> $secretId
https://testxxxx.vault.azure.net:443/certificates/testself/

So below command is correct.

$secretId = $secret.SecretId.Replace($secret.Version, "")
> $secretId
https://testxxxxxx.vault.azure.net:443/secrets/testself/
* update to mgmt ver 11

* update changelog, fix test

* update docs

* simplify Identity pararm type, rerecord

* reference network csproj in sln

* update
…pe (Azure#12111)

* remove duplication of action/conditions.
this fixes the update alert rule issue.

* correct fix - convert the type

* Update ChangeLog.md

Co-authored-by: Aviv Haddad <avhaddad@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
ankushbindlish2 and others added 24 commits June 24, 2020 10:55
* Private link Change  + SSS Recording

* SyncGroup tests

* CloudEndpoint Recording

* Serverendpoint and RegisterServer, MgmtInterop changes

* set storagesyncservice

* Update TestController.cs

* Update Az.StorageSync.psd1
…lInstanceActiveDirectoryAdministrator cmdlet (Azure#12197)

* Allow Azure Active Directory applications to be set as SQL Server Azure Active Directory admin.

* Remove IsAzureADOnlyAuthenticaion option from SetAzureSqlServerActiveDirectoryAdministrator command. We will be adding a new API to enable this option.

* Update ChangeLog.md

* Add Static analysis exception to exceptions file.

* add support for service principal for set aad admin.

* Added support for Service principal and guest users in Set-AzSqlInstanceActiveDirectoryAdministrator cmdlet

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Fix typo in variable name

* Merge with released file.

* Marking MI AAD Admin test as needing re-recording.
After trying multiple times to re-record it, I had no luck.

Co-authored-by: Amol Agarwal <amagarwa@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
…ite resources. (Azure#12213)

* Created Model Classes for NVA powershell object.

* Added *-NetworkVirtualAppliance commands.

* Added *-NVASite commands and export commands.

* Added tests for NVA CRUD operations.

The tests for NVA Site CRUD operations is in skipped state.
Reason for this is a bug in the Nfv-RP which fails the
New-AzVirtualApplianceSite command. The fix is underway and
Nfv-RP team will record the tests and push it in a separate change.

* Added help files for the new 11 Cmdlets.

* Added entry in the Changelog

* Bug fix for null NVA Id.

* Added online version to help files.

* Replace real guids with 0000.. in examples.

* Add default resource paramsets, rename plural cmds

* Supress static analysis errors.

Co-authored-by: Neel Bhavsar <nebhavsa@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* update reference to common

* upgrade reference in generic provider
* Update powershell-core.yml

* Change test framework

* Update powershell-core.yml

* Update Az.Test.props

* Update windows-powershell.yml

* Skip Sql tests

* Skipping SqlVM Unite test

* Skipp SqlVM Unit test
…zure#12256)

* Git Azure#11895 and Azure#5983

* Fix for Azure#12015- Set-AzWebAppSlot incorrectly formats serverFarmId causing Service Plan not found error

* Updated ChangeLog.md

* Fix for Azure#12015- Set-AzWebAppSlot incorrectly formats serverFarmId causing Service Plan not found error

* fix Azure#11862 - Added support to use Id for Restore-AzDeletedWebApp.
- Add new examples to the following modules:
		Compute

Co-authored-by: Maoliang Huang <mahuang@microsoft.com>
* add macos back

* Update Automation.Test.csproj

* Update Storage.Test.csproj
* Rollback breaking changes from PR Azure#12141

* Fix changelog

* Fix changelog
* Update ProviderConfiguration.cs

* Update ProviderConfiguration.cs

* changelog

* Update ProviderConfiguration.cs
* Fix parameter swap in hubvnet connection cmdlet

* Update ChangeLog.md

Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Removed invalid example
* use mutex to prevent cross process writing

to token cache file

* prevent cross-process write to profile file

* change log

* Use "Local" mutex; put ReleaseMutex() in finally
NIC renaming changes for TFO/FO
@blueww blueww added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Jun 30, 2020
@blueww blueww requested a review from anton-evseev as a code owner June 30, 2020 09:37
@VeryEarly VeryEarly self-assigned this Jul 1, 2020
@VeryEarly VeryEarly merged commit fe455c5 into Azure:Az.Storage-preview Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. needs-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.