Skip to content

Add new module CustomProviders, HanaOnAzure, MonitoringSolutions, ConnectedK8s, and K8sConfiguration #12329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dingmeng-xue merged 18 commits into from
Jul 7, 2020
Merged

Add new module CustomProviders, HanaOnAzure, MonitoringSolutions, ConnectedK8s, and K8sConfiguration #12329

dingmeng-xue merged 18 commits into from
Jul 7, 2020

Conversation

@isra-fel
Copy link
Member

@isra-fel isra-fel commented Jul 6, 2020 •
edited
Loading

Description

Modules:

  • Az.MonitoringSolutions
    • Operations of Microsoft first party solutions.
  • Az.CustomProvider
    • Operations of custom resource provider and association.
  • Az.HanaOnAzure
    • Operations of SAP monitor and provider instance.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Jul 6, 2020

Can one of the admins verify this patch?

@isra-fel isra-fel added this to the S172 (2020-07-14) milestone Jul 6, 2020
@isra-fel
Copy link
Member Author

isra-fel commented Jul 7, 2020

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Jul 7, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel
Copy link
Member Author

isra-fel commented Jul 7, 2020

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Jul 7, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel
Copy link
Member Author

isra-fel commented Jul 7, 2020

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Jul 7, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@dingmeng-xue dingmeng-xue changed the title Generated modules in S172 Add new module CustomProviders, HanaOnAzure, and MonitoringSolutions Jul 7, 2020
@dingmeng-xue dingmeng-xue requested a review from dolauli July 7, 2020 10:58
dolauli
dolauli reviewed Jul 7, 2020
View reviewed changes
dolauli
dolauli previously approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dingmeng-xue dingmeng-xue changed the title Add new module CustomProviders, HanaOnAzure, and MonitoringSolutions Add new module CustomProviders, HanaOnAzure, MonitoringSolutions, ConnectedK8s, and K8sConfiguration Jul 7, 2020
@dingmeng-xue dingmeng-xue requested a review from wyunchi-ms July 7, 2020 14:46
dolauli
dolauli previously approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dingmeng-xue dingmeng-xue merged commit 2348841 into master Jul 7, 2020
litchiyangMSFT pushed a commit to litchiyangMSFT/azure-powershell that referenced this pull request Aug 4, 2020
@isra-fel @dingmeng-xue
@wyunchi-ms @litchiyangMSFT
Add new module CustomProviders, HanaOnAzure, MonitoringSolutions, Con…
4a50d3f 
…nectedK8s, and K8sConfiguration (Azure#12329)

* Az.MonitoringSolutions

* Az.CustomProvider

* Az.HanaOnAzure

* cred scan

* Add files for release readiness

* Update module list

* Correct project files

* Correct HanaOnAzure solution file

* Add two modules for Kubernetes

* Correct online link of New-AzSapMonitorProviderInstance.md

* Add files for module release

* Fix link in online help

* Fix psd1 issue

* Remove Az.Accounts module from test

Co-authored-by: dingmeng-xue <dixue@microsoft.com>
Co-authored-by: wyunchi-ms <yunwang@microsoft.com>
@wyunchi-ms wyunchi-ms deleted the internal/gen2master branch August 21, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolauli dolauli dolauli left review comments

@wyunchi-ms wyunchi-ms Awaiting requested review from wyunchi-ms

Assignees

@dingmeng-xue dingmeng-xue

Labels

needs-review

Projects

None yet

Milestone

S172 (2020-07-14)

Development

Successfully merging this pull request may close these issues.

6 participants

@isra-fel @adxsdkps @dolauli @dingmeng-xue @wyunchi-ms